View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002785 | FSSCP | user interface | public | 2013-02-01 16:55 | 2013-02-09 01:27 |
| Reporter | Kobrar | Assigned To | niffiwan | ||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.16 | ||||
| Summary | 0002785: Music level resets when you change it in mission. | ||||
| Description | At least some sound settings in options don't seem to be preserved when altered during mission. | ||||
| Steps To Reproduce | One of the ways to reproduce. 1. Run a mission. Most likely ANY, given that it has soundtrack set. 2. Press F2. 3. Change music level to lowest. 4. Go back to mission. 5. Go to F3. 6. Go back to mission. 7. Enjoy the music. Seems to be triggered by music events too. Escaping mission too. In options from menu music level will be the old level again. | ||||
| Tags | No tags attached. | ||||
|
|
Just to make clear, this seems to only affect music level and changing music level to any level does not preserve. When I exit mission and go to options from menu I see the level of music I set, but when I play a mission again, music plays as it played before changing music level. I run mission with music level X, chenge it in mission to Y, escape mission, go to options, see Y, play mission again, hear X while seeing Y in F2. |
|
|
I am only partially able to reproduce this. Your steps work for me only if it's done in the briefing, not the actual mission. When I start the mission, the music volume returns to whatever was set in the options menu. Quitting the mission and loading a different one doesn't return the music volume to what was set initially. |
|
|
I didn't even try to alter the music level in the briefing. I'll make more testing today. The two ways I wrote about should definitely work. |
|
|
Looks like F3 (hotkey screen) paused the music on entering, and then always set the default volume level (i.e. 50%) on exiting, regardless of the setting beforehand. Patch attached that should restore the previous volume level for any paused sounds. |
|
|
mantis2785-svn.patch (425 bytes)
Index: code/sound/audiostr.cpp
===================================================================
--- code/sound/audiostr.cpp (revision 9523)
+++ code/sound/audiostr.cpp (working copy)
@@ -1977,7 +1977,7 @@
if ( audiostream_is_paused(i) == (int)true ) {
is_looping = Audio_streams[i].Is_looping();
- audiostream_play(i, -1.0f, is_looping);
+ audiostream_play(i, Audio_streams[i].Get_Volume(), is_looping);
}
}
|
|
|
Fix committed to trunk@9527. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-02-01 16:55 | Kobrar | New Issue | |
| 2013-02-01 17:27 | Kobrar | Note Added: 0014677 | |
| 2013-02-01 23:54 | Yarn | Note Added: 0014678 | |
| 2013-02-02 13:03 | Kobrar | Note Added: 0014681 | |
| 2013-02-05 09:54 | niffiwan | Assigned To | => niffiwan |
| 2013-02-05 09:54 | niffiwan | Status | new => assigned |
| 2013-02-05 11:21 | niffiwan | Relationship added | duplicate of 0002511 |
| 2013-02-05 11:22 | niffiwan | Note Added: 0014685 | |
| 2013-02-05 11:22 | niffiwan | Note Edited: 0014685 | |
| 2013-02-05 11:24 | niffiwan | File Added: mantis2785-svn.patch | |
| 2013-02-05 11:24 | niffiwan | Status | assigned => code review |
| 2013-02-09 01:27 | niffiwan | Changeset attached | => fs2open trunk r9527 |
| 2013-02-09 01:27 | niffiwan | Note Added: 0014690 | |
| 2013-02-09 01:27 | niffiwan | Status | code review => resolved |
| 2013-02-09 01:27 | niffiwan | Resolution | open => fixed |
