2018-09-26 05:59 EDT


View Issue Details Jump to Notes ] Related Changesets ]
IDProjectCategoryView StatusLast Update
0002666FSSCPHUDpublic2012-07-01 21:25
ReporterYarn 
Assigned Toniffiwan 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Platformx64OSWindows 7OS Version
Product Version3.6.14 RC5 
Target VersionFixed in Version 
Summary0002666: Background for red-alert "downloading new orders..." message not positioned correctly in custom HUD layouts
DescriptionIf the "downloading new orders..." message appears and a custom HUD layout is being used, the background for that message (but not the text itself) will be positioned and scaled for a 1024x768 HUD, regardless of the current HUD's actual resolution.
Steps To Reproduce1) Make sure that a mod with a widescreen HUD (such as FSPort 3.3 with MediaVPs) is selected and that your game is configured for a widescreen resolution.

2) Play a mission that ends in red alert, such as one of the attached missions.

3) When the "downloading new orders..." message appears, notice where the message background is. It will probably be below and to the right of the message text.
Additional InformationThis problem also occurs in r8892 and RC6.
TagsNo tags attached.
Attached Files
  • ? file icon RedAlertTestFSPort.fs2 (3,122 bytes) 2012-06-16 16:11
  • ? file icon RedAlertTestFS2.fs2 (3,364 bytes) 2012-06-16 16:12
  • jpg file icon RedAlert.jpg (19,626 bytes) 2012-06-16 16:12 -
    jpg file icon RedAlert.jpg (19,626 bytes) 2012-06-16 16:12 +
  • png file icon ApplyError1.png (70,879 bytes) 2012-06-22 13:55 -
    png file icon ApplyError1.png (70,879 bytes) 2012-06-22 13:55 +
  • png file icon ApplyError2.png (44,399 bytes) 2012-06-22 13:55 -
    png file icon ApplyError2.png (44,399 bytes) 2012-06-22 13:55 +
  • patch file icon mantis2666.patch (551 bytes) 2012-06-22 19:05 -
    Index: code/hud/hud.cpp
    ===================================================================
    --- code/hud/hud.cpp    (revision 8899)
    +++ code/hud/hud.cpp    (working copy)
    @@ -3383,7 +3383,7 @@ void HudGaugeObjectiveNotify::renderRedAlert()
    	// Blit the background
    	gr_set_color_fast(&Color_red);		// Color box red, because it's an emergency
     
    -	GR_AABITMAP(Objective_display_gauge.first_frame, position[0], position[1]);	
    +	renderBitmap(Objective_display_gauge.first_frame, position[0], position[1]);
     
    	startFlashNotify();
    	if(maybeFlashNotify()) {
    
    
    patch file icon mantis2666.patch (551 bytes) 2012-06-22 19:05 +

-Relationships
+Relationships

-Notes

~0013687

niffiwan (developer)

The attached patch has fixed the issue in my testing with your missions - could you also run some tests and let me know if this fixes it for you as well? Thanks

~0013694

Yarn (developer)

Last edited: 2012-06-21 14:53

View 3 revisions

I can't get your patch to apply. Could you make another one? I'm applying it as instructed here: http://www.hard-light.net/forums/index.php?topic=74840.msg1479356#msg1479356

~0013697

niffiwan (developer)

I think I know what was wrong with the patch - here's a new one.

~0013698

Yarn (developer)

I still can't apply your patch. I've applied FSO patches before; is this one supposed to be applied differently? (I'm trying to apply this to revision 8897, by the way.)

~0013699

niffiwan (developer)

Sorry about this (one of the pitfalls of using git instead of svn...) - please try this one. If it still doesn't work, please send me a screenshot of the error you get from TortoiseSVN. Oh, and also send me an example of a patch you've applied before so I can figure out what I'm doing wrong :)

~0013702

Yarn (developer)

Here are the errors that I get. The first error appeared only with your first and third attempts, but the second error appeared with all three.

As for what you're doing wrong, the only thing that I can think of is that you're saving the patch outside the fs2_open folder (or whatever your working folder is); it should be saved inside (but not in the subfolders).

I can't remember exactly what patches I've applied in the past, but the one posted to Mantis 0002657 works for me.

~0013703

niffiwan (developer)

fingers crossed - this one should work. You're right, my patches are made from one level higher than the "fs2_open" directory, my local git repository is a copy of everything at trunk (e.g. includes the fsoinstaller & Launcher) which has been causing me various issues. In this patch I've removed the extra directory from the path in the patch, which is what I did in the 2nd patch, however the 2nd patch had the wrong revision...

~0013704

Yarn (developer)

I figured out what the problem was: the patches that you uploaded had spaces instead of tabs in the third and fourth lines. Changing those allowed me to apply the patch.

Anyway, I tested your patch and it worked fine.

~0013706

niffiwan (developer)

Fix committed to trunk@8900.

~0013769

Zacam (administrator)

Fix committed to fs2_open_3_6_14@8958.
+Notes

+Related Changesets

-Issue History
Date Modified Username Field Change
2012-06-16 16:11 Yarn New Issue
2012-06-16 16:11 Yarn File Added: RedAlertTestFSPort.fs2
2012-06-16 16:12 Yarn File Added: RedAlertTestFS2.fs2
2012-06-16 16:12 Yarn File Added: RedAlert.jpg
2012-06-21 02:41 niffiwan Assigned To => niffiwan
2012-06-21 02:41 niffiwan Status new => assigned
2012-06-21 02:41 niffiwan File Added: mantis-2666.patch
2012-06-21 02:44 niffiwan Note Added: 0013687
2012-06-21 02:44 niffiwan Status assigned => feedback
2012-06-21 14:52 Yarn Note Added: 0013694
2012-06-21 14:52 Yarn Status feedback => assigned
2012-06-21 14:53 Yarn Note Edited: 0013694 View Revisions
2012-06-21 14:53 Yarn Note Edited: 0013694 View Revisions
2012-06-21 19:15 niffiwan File Deleted: mantis-2666.patch
2012-06-21 19:16 niffiwan File Added: mantis-2666.patch
2012-06-21 19:17 niffiwan Note Added: 0013697
2012-06-21 19:17 niffiwan Status assigned => feedback
2012-06-21 22:24 Yarn Note Added: 0013698
2012-06-21 22:24 Yarn Status feedback => assigned
2012-06-22 05:12 niffiwan File Deleted: mantis-2666.patch
2012-06-22 05:12 niffiwan File Added: mantis2666.patch
2012-06-22 05:20 niffiwan Note Added: 0013699
2012-06-22 05:20 niffiwan Status assigned => feedback
2012-06-22 13:55 Yarn File Added: ApplyError1.png
2012-06-22 13:55 Yarn File Added: ApplyError2.png
2012-06-22 14:02 Yarn Note Added: 0013702
2012-06-22 14:02 Yarn Status feedback => assigned
2012-06-22 18:57 niffiwan File Deleted: mantis2666.patch
2012-06-22 18:58 niffiwan File Added: mantis2666.patch
2012-06-22 19:05 niffiwan File Deleted: mantis2666.patch
2012-06-22 19:05 niffiwan File Added: mantis2666.patch
2012-06-22 19:10 niffiwan Note Added: 0013703
2012-06-22 19:10 niffiwan Status assigned => feedback
2012-06-22 20:28 Yarn Note Added: 0013704
2012-06-22 20:28 Yarn Status feedback => assigned
2012-06-22 23:02 niffiwan Changeset attached => fs2open trunk r8900
2012-06-22 23:02 niffiwan Note Added: 0013706
2012-06-22 23:02 niffiwan Status assigned => resolved
2012-06-22 23:02 niffiwan Resolution open => fixed
2012-07-01 21:25 Zacam Changeset attached => fs2open fs2_open_3_6_14 r8958
2012-07-01 21:25 Zacam Note Added: 0013769
+Issue History