View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002216 | FSSCP | sound | public | 2010-06-06 07:02 | 2010-06-07 04:08 |
| Reporter | FUBAR-BDHR | Assigned To | taylor | ||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.12 RC2 | ||||
| Fixed in Version | 3.6.12 | ||||
| Summary | 0002216: Sound index -1 causes crash in snd_play_3d() | ||||
| Description | Found this in the explosion effect sexp which defaults to -1 for sound index. There seem to be other places in the code as well that can call the function with a -1 index. Some places check and skip the call though. | ||||
| Additional Information | Build based off of 3.6.13 r6168 Actual error: ERANGE: String error. Please Report. Trying to put into 32 byte buffer: ÍÍÍÍÍÍÍÍÍÍÍÍýýýýÝÝÝÝVj €Ø€ìÕë <no module>! KiFastSystemCallRet <no module>! WaitForSingleObject + 18 bytes <no module>! SCP_DumpStack + 354 bytes <no module>! Error + 229 bytes <no module>! scp_strcpy_s + 297 bytes <no module>! scp_strcpy_s<32> + 53 bytes <no module>! snd_load + 533 bytes <no module>! snd_play_3d + 187 bytes <no module>! sexp_explosion_effect + 1156 bytes <no module>! eval_sexp + 4979 bytes <no module>! eval_when + 1026 bytes <no module>! eval_sexp + 3368 bytes <no module>! mission_process_event + 313 bytes <no module>! mission_eval_goals + 513 bytes <no module>! game_simulation_frame + 1129 bytes <no module>! game_frame + 491 bytes <no module>! game_do_frame + 239 bytes <no module>! game_do_state + 379 bytes <no module>! gameseq_process_events + 237 bytes <no module>! game_main + 782 bytes <no module>! WinMain + 330 bytes <no module>! __tmainCRTStartup + 358 bytes <no module>! WinMainCRTStartup + 15 bytes <no module>! RegisterWaitForInputIdle + 73 bytes | ||||
| Tags | No tags attached. | ||||
|
|
I think I covered all of the missing checks. Please give it a try with current SVN and let me know if it still happens. |
|
|
The sexp one is working fine. Can't say about the rest of the places. Guess those are a wait and see situation. |
|
|
Alright. I'll just resolve this, under the assumption that the other stuff works, and it can be reopened if it shows up again. |
|
|
Fixered. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-06-06 07:02 | FUBAR-BDHR | New Issue | |
| 2010-06-06 13:05 | taylor | Status | new => assigned |
| 2010-06-06 13:05 | taylor | Assigned To | => taylor |
| 2010-06-06 14:49 | taylor | Note Added: 0012045 | |
| 2010-06-06 14:49 | taylor | Status | assigned => feedback |
| 2010-06-07 03:25 | FUBAR-BDHR | Note Added: 0012046 | |
| 2010-06-07 04:08 | taylor | Note Added: 0012047 | |
| 2010-06-07 04:08 | taylor | Note Added: 0012048 | |
| 2010-06-07 04:08 | taylor | Status | feedback => resolved |
| 2010-06-07 04:08 | taylor | Fixed in Version | => 3.6.12 |
| 2010-06-07 04:08 | taylor | Resolution | open => fixed |
