View Issue Details

IDProjectCategoryView StatusLast Update
0002181FSSCPmath-relatedpublic2020-07-07 05:20
ReporterFUBAR-BDHR Assigned ToGoober5000  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version3.6.12 RC2 
Summary0002181: Null vec3d from multi_oo_sort_function() line 181
DescriptionNot even sure that the scenario that led up to this is legal but it probably will be at some point if it's not now. Basically the mission has the player starts set to docking bay of a Hecate. Problem is there are at least 6 players and only 5 bay paths on the Hecate. It appears Beta2 tried to spawn on top of another ship resulting in both oo_player_object->pos and obj1->pos having the same coordinates.

Probably just needs the same sanity checks added to the other swarm of null vec3d errors.
Additional Information3.6.13 r6046 Inferno SSE2. Standalone server with MediaVPs.
TagsNo tags attached.

Activities

Wanderer

2010-05-29 14:37

developer   ~0012020

Well.. It might require something else. Ships having identical positions is something that code generally assumes to be impossible. Just using normal null vec protection macros is not really a good solution for this issue

Goober5000

2020-07-07 02:48

administrator   ~0017000

PR opened in GitHub:
https://github.com/scp-fs2open/fs2open.github.com/pull/2550

I disagree with Wanderer; I think this fix is sufficient. If there are more ships than bay paths, the code has no choice but to reuse paths.

Goober5000

2020-07-07 05:20

administrator   ~0017002

Fix merged.

Issue History

Date Modified Username Field Change
2010-04-13 22:02 FUBAR-BDHR New Issue
2010-05-29 14:37 Wanderer Note Added: 0012020
2020-07-07 02:48 Goober5000 Assigned To => Goober5000
2020-07-07 02:48 Goober5000 Status new => confirmed
2020-07-07 02:48 Goober5000 Note Added: 0017000
2020-07-07 05:20 Goober5000 Status confirmed => resolved
2020-07-07 05:20 Goober5000 Resolution open => fixed
2020-07-07 05:20 Goober5000 Note Added: 0017002