View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001922 | FSSCP | graphics | public | 2009-05-04 18:41 | 2012-12-05 08:34 |
| Reporter | Sushi_CW | Assigned To | niffiwan | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.9 | ||||
| Fixed in Version | 3.6.15 | ||||
| Summary | 0001922: Glowmaps not applied for target preview window | ||||
| Description | As in the title, texture replacement doesn't seem to be applied in the target preview window. I noticed this when playing Derelict in all of the missions where the Nyarlathotep is visible but hasn't yet come to life: although it looks black in the main game screen, the mini target-preview window in the bottom left shows the normal red Lucifer textures. Not a huge issue, but it does break some of the immersion. | ||||
| Additional Information | Using 3.6.10 RC1, MediaVPs 3.6.10 | ||||
| Tags | No tags attached. | ||||
|
|
That's not texture replacement, that's glow mapping. Valid question though. |
|
|
Can we get a means of reproducing with retail data? |
|
|
That's not possible because this problem only shows up with a model that has glowmapping. So you'd need the mediavps at very least. I don't think that Derelict mission includes any custom ships; you could probably extract it and test it without having the Derelict mod active. |
|
|
Here "retail" = standard campaign with mediavps. Much clearer now. I don't have Derelict, and didn't want to download, setup and test if there's a quicker way to repro. |
|
2011-01-16 04:49
|
|
|
|
I've uploaded the mission where the Nyarlathotep "comes to life". The only non-retail ship in that mission is the GTFf Saphah, but you can swap the Iceni for that. |
|
|
|
|
|
Updated mission with Iceni replacing Saphah and a couple of events to activate/deactive glowmaps for easier testing. I've got a potential fix by setting MR_NO_GLOWMAPS in hud/hudtargetbox.cpp - but given there's already code to set MR_NO_GLOWMAPS in model/modelinterp.cpp model_really_render() I just want to do a bit more checking before posting the patch. |
|
|
mantis1922.svn.patch (760 bytes)
Index: code/hud/hudtargetbox.cpp
===================================================================
--- code/hud/hudtargetbox.cpp (revision 9392)
+++ code/hud/hudtargetbox.cpp (working copy)
@@ -583,6 +583,12 @@
if (!Glowpoint_override)
Glowpoint_override = true;
+ // set glowmap flag here since model_render (etc) require an objnum to handle glowmaps
+ // if we did pass the objnum, we'd also have thrusters drawn in the targetbox
+ if (target_shipp->flags2 & SF2_GLOWMAPS_DISABLED) {
+ flags |= MR_NO_GLOWMAPS;
+ }
+
// maybe render a special hud-target-only model
if(target_sip->model_num_hud >= 0){
model_render( target_sip->model_num_hud, &target_objp->orient, &obj_pos, flags | MR_LOCK_DETAIL | MR_AUTOCENTER | MR_NO_FOGGING);
|
|
|
See attached patch - tested successfully with the attached mission(s). |
|
|
Tested successfully here too. |
|
|
Looks good throw it in. |
|
|
Thanks for the review & testing. Committed in r9398 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-05-04 18:41 | Sushi_CW | New Issue | |
| 2009-05-04 19:25 | Goober5000 | Note Added: 0010867 | |
| 2011-01-15 08:09 | Echelon9 | Note Added: 0012599 | |
| 2011-01-15 08:22 | Goober5000 | Note Added: 0012600 | |
| 2011-01-15 08:23 | Goober5000 | Note Edited: 0012600 | |
| 2011-01-15 08:23 | Goober5000 | Note Edited: 0012600 | |
| 2011-01-15 09:17 | Echelon9 | Note Added: 0012601 | |
| 2011-01-16 04:49 | Goober5000 | File Added: dl2-11.fs2 | |
| 2011-01-16 04:50 | Goober5000 | Note Added: 0012602 | |
| 2012-12-03 10:15 | niffiwan | Assigned To | => niffiwan |
| 2012-12-03 10:15 | niffiwan | Status | new => assigned |
| 2012-12-03 10:15 | niffiwan | Summary | Texture Replacement not applied for target preview window => Glowmaps not applied for target preview window |
| 2012-12-03 10:16 | niffiwan | File Added: dl2-11-festive.fs2 | |
| 2012-12-03 10:21 | niffiwan | Note Added: 0014269 | |
| 2012-12-04 10:19 | niffiwan | File Added: mantis1922.svn.patch | |
| 2012-12-04 10:28 | niffiwan | Note Added: 0014284 | |
| 2012-12-04 10:28 | niffiwan | Status | assigned => code review |
| 2012-12-04 19:00 | MjnMixael | Note Added: 0014290 | |
| 2012-12-04 23:07 | Valathil | Note Added: 0014293 | |
| 2012-12-05 08:34 | niffiwan | Note Added: 0014303 | |
| 2012-12-05 08:34 | niffiwan | Status | code review => resolved |
| 2012-12-05 08:34 | niffiwan | Fixed in Version | => 3.6.15 |
| 2012-12-05 08:34 | niffiwan | Resolution | open => fixed |
