View Issue Details

IDProjectCategoryView StatusLast Update
0001134FSSCPgameplaypublic2012-01-09 18:06
ReporterArcanum Assigned Totaylor  
PrioritynormalSeveritycrashReproducibilitysometimes
Status resolvedResolutionfixed 
Product Version3.6.9 
Fixed in Version3.6.9 
Summary0001134: c -> all fighters -> ignore my target -> assert fail (FSP/FS1 "Where Eagles Dare", sm2-04a)
DescriptionAssert: shipnum != -1
File: c:\temp\fs2_open_3_6_9.t\code\hud\hudsquadmsg.cpp
Line: 1439
[This filename points to the location of a file on the computer that built this executable]

Call stack:
------------------------------------------------------------------
    hud_squadmsg_ship_command() hud_squadmsg_do_frame() HUD_render_2d() game_render_hud_2d() game_frame() game_do_frame() game_do_state() gameseq_process_events() game_main() WinMain() WinMainCRTStartup() kernel32.dll 7c816fd7()
------------------------------------------------------------------

FSO: 3.6.9 RC7
FSP: 3.0.3
Additional InformationCrashes when telling your wingmen to ignore my target. I've reproduced it by playing the mission through normally, except I c-3-6 every ship I attack. Specifically, I think it may happen when you tell them to ignore the last hostile ship left alive, the last hostile ship in Gemini wing, or a specific ship in Gemini wing.

Totally unrelated, and possibly doesn't belong here, but the GVT Isis transports in this mission tumble about rediculously fast, sometimes over 100 m/s. It practically suicide to get within 0000083:0000200 m of them.
TagsNo tags attached.

Activities

Arcanum

2006-11-03 02:08

reporter   ~0007063

Narrowed it down. Happens specifically if you order all to ignore Gemini 1, when it's the last remaining ship in Gemini wing (likely, since I think its furthest away).

2006-11-03 20:38

 

sm2-04a.fs2 (50,078 bytes)

karajorma

2006-11-03 20:40

administrator   ~0007067

I've just attached a file. I suspect your problem is due to the fact that for some reason the wing is being lead by Gemini 3 instead of Gemini 1.

Can you test that version of the mission and get back to me as to whether it works or not?

Arcanum

2006-11-03 23:14

reporter   ~0007068

The altered mission resolves this bug, and apparently 1135 as well, but... shouldn't you be able to make any ship in a wing the leader? It may be a good convention, but there's no hard-and-fast rule (AFAIK) that "the leader of xxx wing must be 'xxx 1'"

karajorma

2006-11-03 23:24

administrator   ~0007069

Last edited: 2006-11-03 23:25

You should be able to do that based on the fact that you can define it in FRED. I just wanted to see if my hunch as to the cause was correct and get you back to playing the game as quickly as possible. Now we have a bit more time to solve the problem :)

taylor

2006-11-06 10:35

administrator   ~0007085

This isn't the first time this same basic issue has come up. I'll go ahead and fix it like the last time, and if it tests ok (there were several other areas where this could be an issue too), I'll commit the fix later today.

Arcanum

2006-11-07 02:50

reporter   ~0007097

I'm using dot9 now, and I ran into the same assert in stmm-10, Return to Ross 128 (Silent Threat). Slightly different message, due to different compilation I guess. This mission also has a wing led by other than 0000001.

Assert: shipnum != -1
File: j:\src\cvs\fs2_open_3_6_9.rc7dot9\code\hud\hudsquadmsg.cpp
Line: 1442
[This filename points to the location of a file on the computer that built this executable]

Call stack:
------------------------------------------------------------------
    hud_squadmsg_ship_command() hud_squadmsg_do_frame() HUD_render_2d() game_render_hud_2d() game_frame() game_do_frame() game_do_state() gameseq_process_events() game_main() WinMain() WinMainCRTStartup() kernel32.dll 7c816fd7()
------------------------------------------------------------------

taylor

2006-11-15 00:54

administrator   ~0007124

Should be dealt with properly now. If you see it again in a newer build then just reopen this bug.

Fixered.

Related Changesets

fs2open: fs2_open_3_6_9 r3739

2006-11-14 19:33

taylor


Ported: N/A

Details Diff
add some needed wing leader checks to prevent Assert()'s and out-of-bounds problems when the leader is dead/dying (Mantis bug 0001134)
Affected Issues
0001134
mod - /branches/fs2_open_3_6_9/fs2_open/code/ai/aigoals.cpp Diff File
mod - /branches/fs2_open_3_6_9/fs2_open/code/hud/hudsquadmsg.cpp Diff File
mod - /branches/fs2_open_3_6_9/fs2_open/code/mission/missionhotkey.cpp Diff File
mod - /branches/fs2_open_3_6_9/fs2_open/code/parse/sexp.cpp Diff File

fs2open: trunk r3753

2006-11-15 19:52

taylor


Ported: N/A

Details Diff
add some needed wing leader checks to prevent Assert()'s and out-of-bounds problems when the leader is dead/dying (Mantis bug 0001134)
Affected Issues
0001134
mod - /trunk/fs2_open/code/ai/aigoals.cpp Diff File
mod - /trunk/fs2_open/code/hud/hudsquadmsg.cpp Diff File
mod - /trunk/fs2_open/code/mission/missionhotkey.cpp Diff File
mod - /trunk/fs2_open/code/parse/sexp.cpp Diff File

Issue History

Date Modified Username Field Change
2006-11-03 01:22 Arcanum New Issue
2006-11-03 02:08 Arcanum Note Added: 0007063
2006-11-03 20:38 karajorma File Added: sm2-04a.fs2
2006-11-03 20:40 karajorma Note Added: 0007067
2006-11-03 23:14 Arcanum Note Added: 0007068
2006-11-03 23:24 karajorma Note Added: 0007069
2006-11-03 23:25 karajorma Note Edited: 0007069
2006-11-06 10:35 taylor Note Added: 0007085
2006-11-06 10:35 taylor Status new => assigned
2006-11-06 10:35 taylor Assigned To => taylor
2006-11-07 02:50 Arcanum Note Added: 0007097
2006-11-15 00:54 taylor Status assigned => resolved
2006-11-15 00:54 taylor Fixed in Version => 3.6.9
2006-11-15 00:54 taylor Resolution open => fixed
2006-11-15 00:54 taylor Note Added: 0007124
2012-01-05 22:55 taylor Changeset attached => Import 2012-01-05 17:52:05 fs2_open_3_6_9 r3739
2012-01-05 22:55 taylor Changeset attached => Import 2012-01-05 17:52:05 trunk r3753
2012-01-09 18:06 taylor Changeset attached => fs2open_websvn fs2_open_3_6_9 r3739
2012-01-09 18:06 taylor Changeset attached => fs2open_websvn trunk r3753