Source Code Project Mantis - FSSCP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003209FSSCPPilot datapublic2020-07-13 07:122020-12-24 04:56
ReporterMatthTheGeek 
Assigned ToGoober5000 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSWindowsOS Version
Product Version19.0.0 
Target VersionFixed in Version 
Summary0003209: Special characters in ship names will break JSON pilot
DescriptionFirst found in Procyon Insurgency, which has a ship named GTF Erinyes².

When killed by the player, the JSON will end up with a scoring entry with no name value, resulting in a JSON crash at game start.

Of course this is mostly a modder issue here (don't use freaking special characters when we have "#name" available for ship names), but I feel like debug should at least throw a warning when parsing that ship entry. Right now FSO loads this ship fine (except for the specific JSON issue).
TagsNo tags attached.
Relationships
Attached Files

Notes
(0017006)
Goober5000   
2020-07-13 13:15   
The unprintable character trick has been around ever since retail days. The # symbol in ship names wasn't supported until a few years into FSO's existence. (However the # symbol in ship class names has been supported since FS1.)

This is most likely a character encoding issue.
(0017007)
Goober5000   
2020-07-13 16:22   
Fixed in this PR:
https://github.com/scp-fs2open/fs2open.github.com/pull/2569

Issue History
Date ModifiedUsernameFieldChange
2020-07-13 07:12MatthTheGeekNew Issue
2020-07-13 13:15Goober5000Note Added: 0017006
2020-07-13 16:22Goober5000Assigned To => Goober5000
2020-07-13 16:22Goober5000Statusnew => code review
2020-07-13 16:22Goober5000Note Added: 0017007
2020-12-24 04:56Goober5000Statuscode review => resolved
2020-12-24 04:56Goober5000Resolutionopen => fixed