Source Code Project Mantis - FSSCP
View Issue Details
0003156FSSCPbeamspublic2015-04-06 13:442015-04-17 09:00
ReporterMatthTheGeek 
Assigned Tom_m 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.7.2 RC4 
Target Version3.7.2Fixed in Version 
Summary0003156: Fighter beam range depends on target radius
DescriptionWhen +Range is defined in the $BeamInfo parameters of a fighter beam, the actual effective range of the beam ingame seems to vary based on the radius of the target.

In the test mod attached, a fighter beam with a +Range of 1000 is unable to hit an Orion 1.7km away, but can hit a Colossus 3.3km away.
TagsNo tags attached.
Attached Filesrar fighterbeamtest.rar (3,850) 2015-04-06 13:44
http://scp.indiegames.us/mantis/file_download.php?file_id=2681&type=bug
patch beam.cpp.patch (1,535) 2015-04-17 03:44
http://scp.indiegames.us/mantis/file_download.php?file_id=2698&type=bug

Notes
(0016600)
m_m   
2015-04-06 15:53   
The current collision code doesn't check if a detected collision is actually in range of the beam as the collision code will return every collision it can find.
I added a condition for beams where +Range is less than the far distance which checks the shield and hull collisions and invalidates them if the actual hit position is out of reach for the beam.
(0016644)
m_m   
2015-04-17 09:00   
Fix committed to trunk@11307.

Issue History
2015-04-06 13:44MatthTheGeekNew Issue
2015-04-06 13:44MatthTheGeekFile Added: fighterbeamtest.rar
2015-04-06 15:53m_mNote Added: 0016600
2015-04-06 15:53m_mAssigned To => m_m
2015-04-06 15:53m_mStatusnew => code review
2015-04-06 15:53m_mFile Added: beam.cpp.patch
2015-04-17 03:44m_mFile Deleted: beam.cpp.patch
2015-04-17 03:44m_mFile Added: beam.cpp.patch
2015-04-17 03:46m_mTarget Version => 3.7.2
2015-04-17 09:00m_mChangeset attached => fs2open trunk r11307
2015-04-17 09:00m_mNote Added: 0016644
2015-04-17 09:00m_mStatuscode review => resolved
2015-04-17 09:00m_mResolutionopen => fixed