Source Code Project Mantis - FSSCP
View Issue Details
0003131FSSCPscriptingpublic2014-11-24 04:142014-11-24 09:47
Reporterm_m 
Assigned Tom_m 
PrioritynormalSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.7.1 
Target Version3.7.2Fixed in Version 
Summary0003131: Having an empty action code block in a scripting table causes a crash
DescriptionAn empty lua action block (see uploaded scripting table) causes a rash while parsing the table.
TagsNo tags attached.
Attached Files? require-sct.tbm (82) 2014-11-24 04:14
http://scp.indiegames.us/mantis/file_download.php?file_id=2625&type=bug
patch 3131.patch (524) 2014-11-24 04:18
http://scp.indiegames.us/mantis/file_download.php?file_id=2626&type=bug

Notes
(0016402)
m_m   
2014-11-24 04:18   
alloc_block returns a NULL pointer when the parsed block is empty. That value should only be returned when a serious error was detected (in this case vm_malloc failed to allocate memory).
The uploaded patch fixes this behavior by removing that condition.
(0016403)
Goober5000   
2014-11-24 09:47   
Fix committed to trunk@11179.

Issue History
2014-11-24 04:14m_mNew Issue
2014-11-24 04:14m_mStatusnew => assigned
2014-11-24 04:14m_mAssigned To => m_m
2014-11-24 04:14m_mFile Added: require-sct.tbm
2014-11-24 04:18m_mNote Added: 0016402
2014-11-24 04:18m_mStatusassigned => code review
2014-11-24 04:18m_mFile Added: 3131.patch
2014-11-24 09:47Goober5000Changeset attached => fs2open trunk r11179
2014-11-24 09:47Goober5000Note Added: 0016403
2014-11-24 09:47Goober5000Statuscode review => resolved
2014-11-24 09:47Goober5000Resolutionopen => fixed