Source Code Project Mantis - FSSCP
View Issue Details
0003001FSSCPFREDpublic2014-01-19 11:522014-07-03 01:15
ReporterAxem 
Assigned ToGoober5000 
PrioritynormalSeverityblockReproducibilityalways
StatusresolvedResolutionreopened 
PlatformOSOS Version
Product Version3.7.1 
Target VersionFixed in Version 
Summary0003001: Multiline comments problems
DescriptionIn rev 9945 Goober added !* *! as a new way to do multi-line comments.

But in JAD2.21, Mission 5a (the race mission), there is a message...

$Name: Everyone - GASP!
$Team: -1
$MessageNew: XSTR("*GASP!*", -1)
$end_multi_text

Starting a giant 450 line comment that never ends.

Can we pick a better token for multi line comments?
TagsNo tags attached.
related to 0003072resolved Goober5000 German section of retail strings.tbl crashes game 
Attached Filespatch 3001.patch (9,781) 2014-03-12 04:09
http://scp.indiegames.us/mantis/file_download.php?file_id=2332&type=bug
? CRASHESTHEGAME.fs2 (4,881) 2014-06-04 20:40
http://scp.indiegames.us/mantis/file_download.php?file_id=2368&type=bug

Notes
(0015579)
Goober5000   
2014-01-26 14:13   
I'm considering {* and *}. Does anyone know of any missions which might use these character groupings?
(0015581)
Goober5000   
2014-01-26 23:12   
Yarn suggested disabling multiline-comment delimiters in XSTR strings, which seems like the better approach, given that this happens in every other programming language which uses both string literals and comments. So I'll look into that.
(0015584)
Axem   
2014-02-02 12:11   
Soooo... When can this be fixed?
(0015585)
Goober5000   
2014-02-03 21:29   
Well, a lot of people have their hackles raised about the installer situation, so that's my first priority. After that, I have a patch by m!m for the SEXP system that needs integrating. But I think this can be next on the list.

Of course, if anyone else feels like disabling comments within quoted strings, they are welcome to take a stab at it. :)
(0015636)
Goober5000   
2014-03-04 01:06   
I intend to fix this this week. Axem, feel free to pester me until I do.
(0015649)
Goober5000   
2014-03-12 04:10   
Comment technique rewritten. Axem, can you test the attached patch?
(0015652)
Goober5000   
2014-03-12 22:00   
Fix committed to trunk@10492.
(0015794)
Axem   
2014-06-04 20:40   
This can still trigger. On trying some things out I think its the recommendations that !* can still cause the game to wig out.
(0015797)
Goober5000   
2014-06-04 21:57   
Looks like it's not the recommendations, but rather the fact that the text has embedded newlines.
(0015798)
Goober5000   
2014-06-04 22:05   
Fix committed to trunk@10753.

Issue History
2014-01-19 11:52AxemNew Issue
2014-01-19 16:07Goober5000Assigned To => Goober5000
2014-01-19 16:07Goober5000Statusnew => assigned
2014-01-26 14:13Goober5000Note Added: 0015579
2014-01-26 23:12Goober5000Note Added: 0015581
2014-02-02 12:11AxemNote Added: 0015584
2014-02-03 21:29Goober5000Note Added: 0015585
2014-03-04 01:06Goober5000Note Added: 0015636
2014-03-12 04:09Goober5000File Added: 3001.patch
2014-03-12 04:10Goober5000Note Added: 0015649
2014-03-12 22:00Goober5000Changeset attached => fs2open trunk r10492
2014-03-12 22:00Goober5000Note Added: 0015652
2014-03-12 22:00Goober5000Statusassigned => resolved
2014-03-12 22:00Goober5000Resolutionopen => fixed
2014-06-04 20:40AxemNote Added: 0015794
2014-06-04 20:40AxemStatusresolved => feedback
2014-06-04 20:40AxemResolutionfixed => reopened
2014-06-04 20:40AxemFile Added: CRASHESTHEGAME.fs2
2014-06-04 21:57Goober5000Note Added: 0015797
2014-06-04 22:05Goober5000Changeset attached => fs2open trunk r10753
2014-06-04 22:05Goober5000Note Added: 0015798
2014-06-04 22:05Goober5000Statusfeedback => resolved
2014-07-03 01:15YarnRelationship addedrelated to 0003072