Source Code Project Mantis - FSSCP
View Issue Details
0002981FSSCPgameplaypublic2013-12-16 20:102014-05-10 01:01
ReporterDahBlount 
Assigned Toniffiwan 
PriorityimmediateSeverityblockReproducibilitysometimes
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.7.1 
Target Version3.7.2Fixed in Version 
Summary0002981: Exit loop button appears in certain missions and when clicked restarts campaign.
DescriptionOn certain missions after the SOC loop, the Exit Loop button appears in the top right for several missions. When this is clicked on, it restarts the players campaign from the first training mission TSM 103a.

Missions Know to produce problem include:
Pegasus Test mission
Colossus V. Sathanas mission
Possible others.
Steps To ReproduceFinish SOC loop and continue through campaign as normal.
Additional InformationReports from the forums:
http://www.hard-light.net/forums/index.php?topic=86074.0 (pilot file attached)
TagsNo tags attached.
Attached Filesrar Pilots.rar (16,737) 2014-05-09 00:12
http://scp.indiegames.us/mantis/file_download.php?file_id=2350&type=bug
7z mantis2981.7z (21,312) 2014-05-09 00:19
http://scp.indiegames.us/mantis/file_download.php?file_id=2351&type=bug
patch mantis2981-git.patch (677) 2014-05-09 00:28
http://scp.indiegames.us/mantis/file_download.php?file_id=2352&type=bug

Notes
(0015528)
Lykurgos88   
2013-12-21 14:19   
I had this "Exit Loop" button in EVERY single mission after the first SOC loop. I managed to complete the campaign, but clicking this button should be strongly avoided, since it takes you to the first training mission.
(0015533)
Echelon9   
2013-12-26 02:09   
Can you use nightly builds to see which is the first to report this behaviour?
(0015534)
niffiwan   
2013-12-26 05:51   
I suspect (but haven't confirmed) that this is from the 3.7.0 pilot code, I have a fairly clear recollection of seeing the "exit loop" button outside the SOC loops (I didn't press it) while testing antipodes 8 ages ago.
(0015548)
Lykurgos88   
2013-12-30 07:24   
Sorry I'm a bit late with this, but I just might provide some additional information.

So after a 6-year break, I finally made a new fresh install of FSO, complete with the newly released SCP 3.7.0. I played FS2 campaign for 5 missions before changing to fanmade mods. Then afterwards I upgraded to 10150 build and later to 10222 with MediaVP_2014 enabled. I continued the FS2 campaign all the way to the end. I had this "exit loop" button enabled in every mission after the first 3 SOC missions regardless whether I was using the new or the old mediaVP.

I also gave FSO (complete with 10150 build) in a USB stick to my brother and he reported the same thing. Unfortunately he was a bit careless and actually pressed that exit loop button which caused his campaign to reset.

So yeah, this seems to be a post 3.7.0 problem, linked with the new universal pilot code.
(0015728)
Goober5000   
2014-05-08 11:18   
Marking for 3.7.2, and assigning to Niffiwan.
(0015731)
niffiwan   
2014-05-09 00:21   
(Last edited: 2014-05-09 00:34)
*glee* My JSON pilot dump is useful in the 1st serious test I gave it *glee*

The .1 files are from a FSO run that didn't show the exit loop button.
The .2 files are from a FSO run that *did* show the exit loop button.

Looks like some loop data is being scrambled, possibly read in a different order to being written?

$ diff -u Ranger.FreeSpace2.csj.1 Ranger.FreeSpace2.csj.2
--- Ranger.FreeSpace2.csj.1 2014-05-09 14:29:01.621816490 +1000
+++ Ranger.FreeSpace2.csj.2 2014-05-09 14:29:43.134211180 +1000
@@ -281,8 +281,8 @@
         "last ship flown": 57,
         "Campaign.prev_mission": 31,
         "Campaign.next_mission": 32,
- "Campaign.loop_enabled": 0,
- "Campaign.loop_reentry": 19,
+ "Campaign.loop_enabled": 19,
+ "Campaign.loop_reentry": 0,
         "Campaign.num_missions_completed": 32,
         "ships_allowed* (non-zero)": [
             {

(no difference in the .plr files)

(0015732)
niffiwan   
2014-05-09 00:28   
(Last edited: 2014-05-09 00:34)
And that was it, done :)

https://github.com/scp-fs2open/fs2open.github.com/pull/24
https://github.com/niffiwan/fs2open.github.com/commit/867da05dc4708bfc8db3aa647f0d3ed496a1542a

(0015734)
Echelon9   
2014-05-09 20:33   
Niffiwan, that is a great endorsement of the JSON export feature
(0015735)
Goober5000   
2014-05-10 00:54   
Excellent work. :)

Are you going to also patch the SVN repository, or something?
(0015736)
niffiwan   
2014-05-10 01:01   
Fix committed to trunk@10665.

Issue History
2013-12-16 20:10DahBlountNew Issue
2013-12-21 14:19Lykurgos88Note Added: 0015528
2013-12-26 02:09Echelon9Note Added: 0015533
2013-12-26 05:51niffiwanNote Added: 0015534
2013-12-30 07:24Lykurgos88Note Added: 0015548
2014-05-08 08:27The_EPrioritynormal => immediate
2014-05-08 08:27The_ESeverityminor => block
2014-05-08 11:18Goober5000Note Added: 0015728
2014-05-08 11:18Goober5000Assigned To => niffiwan
2014-05-08 11:18Goober5000Statusnew => assigned
2014-05-08 11:18Goober5000Target Version => 3.7.2
2014-05-08 23:50niffiwanStatusassigned => acknowledged
2014-05-09 00:11niffiwanAdditional Information Updatedbug_revision_view_page.php?rev_id=797#r797
2014-05-09 00:12niffiwanFile Added: Pilots.rar
2014-05-09 00:19niffiwanFile Added: mantis2981.7z
2014-05-09 00:21niffiwanNote Added: 0015731
2014-05-09 00:28niffiwanNote Added: 0015732
2014-05-09 00:28niffiwanFile Added: mantis2981-git.patch
2014-05-09 00:34niffiwanNote Edited: 0015732bug_revision_view_page.php?bugnote_id=15732#r799
2014-05-09 00:34niffiwanNote Edited: 0015731bug_revision_view_page.php?bugnote_id=15731#r801
2014-05-09 00:35niffiwanStatusacknowledged => code review
2014-05-09 20:33Echelon9Note Added: 0015734
2014-05-10 00:54Goober5000Note Added: 0015735
2014-05-10 01:01niffiwanChangeset attached => fs2open trunk r10665
2014-05-10 01:01niffiwanNote Added: 0015736
2014-05-10 01:01niffiwanStatuscode review => resolved
2014-05-10 01:01niffiwanResolutionopen => fixed