Source Code Project Mantis - FSSCP
View Issue Details
0002950FSSCPmultiplayerpublic2013-11-06 02:592014-04-22 04:56
Assigned Toniffiwan 
PlatformOSOS Version
Product Version3.7.1 
Target VersionFixed in Version 
Summary0002950: shields-off & shields-on sexps don't work in multi
DescriptionIf you call shields-off on another player ship, the server thinks that the shields are off, but the client doesn't, so HUD displays are not correct.
Steps To ReproduceSee attached multi mission.
Use a/z to disable/enable shields.
Use q to warp in Alpha3
Use 4 to set ETS of Alpha1/2/3 to the values of Alpha 1
TagsNo tags attached.
related to 0002946resolved niffiwan shields-on and shields-off can cause total ETS energy to increase/decrease 
Attached Files? ets_getset_multi.fs2 (6,324) 2013-11-06 03:03
patch mantis2950.patch (6,001) 2013-11-09 21:13

2013-11-06 03:13   
I have a patch, but I'll wait to get feedback on 0002946 prior to committing this one.
2013-11-09 21:13   
Also noticed that alter-ship-flag was broken in multi, added some fixes for that as well
2014-02-22 23:03   
Pull request for code review here:
2014-04-21 02:29   
Hi - I've reviewed the Github pull request and commented there accordingly.

In summary, I think this is fine to commit to SVN trunk and close the pull request and branch (given yet to move fully to Github).
2014-04-22 04:56   
Fix committed to trunk@10587.

Issue History
2013-11-06 02:59niffiwanNew Issue
2013-11-06 02:59niffiwanStatusnew => assigned
2013-11-06 02:59niffiwanAssigned To => niffiwan
2013-11-06 02:59niffiwanRelationship addedrelated to 0002946
2013-11-06 03:03niffiwanFile Added: ets_getset_multi.fs2
2013-11-06 03:12niffiwanFile Added: mantis2950.patch
2013-11-06 03:13niffiwanNote Added: 0015385
2013-11-07 03:16niffiwanFile Deleted: mantis2950.patch
2013-11-07 03:16niffiwanFile Added: mantis2950.patch
2013-11-09 21:13niffiwanFile Deleted: mantis2950.patch
2013-11-09 21:13niffiwanFile Added: mantis2950.patch
2013-11-09 21:13niffiwanNote Added: 0015404
2014-02-22 23:03niffiwanNote Added: 0015630
2014-02-22 23:03niffiwanStatusassigned => code review
2014-04-21 02:29Echelon9Note Added: 0015705
2014-04-22 04:56niffiwanChangeset attached => fs2open trunk r10587
2014-04-22 04:56niffiwanNote Added: 0015707
2014-04-22 04:56niffiwanStatuscode review => resolved
2014-04-22 04:56niffiwanResolutionopen => fixed