Source Code Project Mantis - FSSCP
View Issue Details
0002790FSSCPlauncherpublic2013-02-07 19:282014-07-02 12:09
Reporterjg18 
Assigned Tochief1983 
PriorityhighSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.6.16 
Target Version3.7.2Fixed in Version 
Summary0002790: Easy flags (flag sets for launcher) don't reflect current state of flags
DescriptionFor example, flag set "all features on" doesn't include recent features like soft particles. I don't have the expertise to know what belongs under "high memory features".
Additional InformationWould like to see this fixed in next release (3.7?), since it should be pretty easy.
TagsNo tags attached.
Attached Filesdiff cmdline_cleanup.diff (11,121) 2014-07-01 12:54
http://scp.indiegames.us/mantis/file_download.php?file_id=2441&type=bug

Notes
(0015952)
Goober5000   
2014-06-29 23:20   
Chief1983 can probably compile a list of the features and make sure the easy-flags list is up to date.
(0015966)
chief1983   
2014-06-30 10:20   
Well, the reference for all command line options is always at http://www.hard-light.net/wiki/index.php/Command-Line_Reference

The launcher should of course always provide an up to date output of available flags as well, in case any are missing from the Wiki.

Also, that wiki page desperately needs an update since many flags behavior was toggled, with new flag names like -nospec, -noglow, etc.

I don't really feel any better qualified than the next person to decide if one feature or another belongs in a particular memory set as I'm not really knowledgeable about the implementation details of any new FSO features, so I'll be unassigning this from me, thanks.
(0015974)
chief1983   
2014-06-30 15:17   
Ok fine maybe I will do this after all.
(0015976)
chief1983   
2014-06-30 17:14   
(Last edited: 2014-06-30 17:42)
Ok, I've attached a patch that cleans up the ordering a bit, and toggles the memory and all options features on a bunch of the flags to make a bit more sense. Some flags' behaviors were toggled without adjusting their behavior with regards to the Easy options, these should all be addressed now. I haven't tested it but wanted to get this out in case I run out of time here before I head home. Also, I made a series of updates to the Command Line Reference on the wiki to correspond with some things I saw, please take a look at http://www.hard-light.net/wiki/index.php?title=Command-Line_Reference&action=history as well to see my changes.

One strange thing I noticed is that -no_fps_capping was not documented or in the Launcher checklist, yet it seems to be set up to function in the code, so I've added it to both.

Edit: Uploaded a new version just now that fixes a missing comma. Seems to compile and work now.

(0015989)
Goober5000   
2014-06-30 22:07   
Ah, very good. :)

MjnMixael, can you test this to see if the flag lists reasonably make sense now?
(0015995)
MjnMixael   
2014-06-30 23:44   
The organization looks good.

'All Features On' doesn't include the various HUD and game-play features. Is there a reason for that? (scanning lines, target info, 3D models for selection, etc.) Would those same ones be used in 'High Memory Usage Features'?

I know some of them can be left to personal preference. (And I still really think many of those should be moved the game_settings and out of the commandline...) I'm thinking that new users would expect some of those. Maybe?
(0016001)
chief1983   
2014-07-01 09:43   
The options in the HUD and Gameplay sections are much older, and since they were never added to the Easy flags in the past, I didn't see a reason to do it now. Most of the flag changes I've made are to flags that have been added or modified in the last few years, since the last time anyone apparently paid much attention to these. And yes, I also do believe they're more of a preference thing too. I probably should have left 3d shockwaves off with the All Options On since it's a highly debated 'improvement' too, but I think most of the other features that get turned on are universally agreed to be enhancements.

Actually 3d shockwaves isn't one I changed, so I've just left its behavior alone. I don't want to open a can of worms by messing with that particular one.

(0016010)
MjnMixael   
2014-07-02 00:23   
Sounds good to me then.
(0016011)
chief1983   
2014-07-02 12:09   
Fix committed to trunk@10869.

Issue History
2013-02-07 19:28jg18New Issue
2014-06-29 23:20Goober5000Note Added: 0015952
2014-06-29 23:20Goober5000Assigned To => chief1983
2014-06-29 23:20Goober5000Statusnew => assigned
2014-06-30 10:20chief1983Note Added: 0015966
2014-06-30 10:20chief1983Assigned Tochief1983 =>
2014-06-30 15:17chief1983Assigned To => chief1983
2014-06-30 15:17chief1983Note Added: 0015974
2014-06-30 17:12chief1983File Added: cmdline_cleanup.diff
2014-06-30 17:14chief1983Note Added: 0015976
2014-06-30 17:16chief1983Statusassigned => code review
2014-06-30 17:16chief1983Target Version => 3.7.2
2014-06-30 17:36chief1983File Deleted: cmdline_cleanup.diff
2014-06-30 17:42chief1983File Added: cmdline_cleanup.diff
2014-06-30 17:42chief1983Note Edited: 0015976bug_revision_view_page.php?bugnote_id=15976#r844
2014-06-30 22:07Goober5000Note Added: 0015989
2014-06-30 22:07Goober5000Assigned Tochief1983 => MjnMixael
2014-06-30 23:44MjnMixaelNote Added: 0015995
2014-07-01 09:43chief1983Note Added: 0016001
2014-07-01 09:43chief1983Note Edited: 0016001bug_revision_view_page.php?bugnote_id=16001#r850
2014-07-01 12:53chief1983File Deleted: cmdline_cleanup.diff
2014-07-01 12:54chief1983File Added: cmdline_cleanup.diff
2014-07-02 00:23MjnMixaelNote Added: 0016010
2014-07-02 11:52chief1983Assigned ToMjnMixael => chief1983
2014-07-02 11:52chief1983Statuscode review => assigned
2014-07-02 12:09chief1983Changeset attached => fs2open trunk r10869
2014-07-02 12:09chief1983Note Added: 0016011
2014-07-02 12:09chief1983Statusassigned => resolved
2014-07-02 12:09chief1983Resolutionopen => fixed