Source Code Project Mantis - FSSCP
View Issue Details
0002788FSSCPAIpublic2013-02-07 00:032013-02-10 04:36
ReporterWoolie Wool 
Assigned ToThe_E 
PriorityimmediateSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformAMD Phenom IIOSWindowsOS VersionVista
Product Version3.6.16 
Target VersionFixed in Version 
Summary0002788: Difficulty level appears locked on Insane
DescriptionThe difficulty level for the game appears stuck on Insane, at least in regards to weapon fire rates and damage scaling. No matter how low you set the difficulty, enemy weapons will always do full damage.
Steps To ReproduceSet the difficulty to Very Easy. Load an FSPort mission with no shields (for instance, Small Deadly Space from the original FS1 campaign, The Fifth Column from the Twist of Fate Demo). Allow enemies to shoot you.

Vasudan Light Lasers will do 2-4% damage depending on whether one or both bolts hit.

Terran Turrets will do around 18% damage.

Being near (<150 m) an exploding Ma'at in Small Deadly Space will do catastrophic damage, perhaps killing you outright.

On older builds (the one I cross-tested on was dated 12/28/11), damage done by these weapons on Very Easy is one fourth this amount, as intended.
TagsNo tags attached.
Attached Files? WeaponDamageTest.fs2 (5,260) 2013-02-07 19:00
http://scp.indiegames.us/mantis/file_download.php?file_id=2110&type=bug
patch 2788.patch (4,750) 2013-02-09 18:32
http://scp.indiegames.us/mantis/file_download.php?file_id=2111&type=bug

Notes
(0014686)
Woolie Wool   
2013-02-07 00:07   
3.6.14 RC8 is not affected by this bug so it must have crept in during the 3.6.15 cycle.
(0014687)
niffiwan   
2013-02-07 05:45   
(Last edited: 2013-02-07 05:47)
I have reproduced this with a little debug code to output the amount of damage taken by ships. I think it was introduced in r8629.

Tested in Easy (2/5), no mods active

r8628 I'm taking 6.75 hull damage from Subach's
r8629 I'm taking 13.5 hull damage from Subach's

I'll attach my test mission (which is just a hacked up version of an Axem test mission :nervous:)

(0014688)
Yarn   
2013-02-07 19:00   
I can confirm that the bug was indeed introduced in r8629.

I have uploaded another test mission that should test this bug more reliably.
(0014689)
Zacam   
2013-02-08 19:00   
(Last edited: 2013-02-08 22:05)
Has anyone thought to check the damage scaling (pre and post) based on ALL the difficulty levels?

And yes. Woolie was kind enough to do exactly that over IRC with me.
Hull integrity damage reduction on an unshielded Apollo from a Terran Turret using the FS2 default AI profile, from Very Easy to Insane: 5, 9, 12, 15, 18

Is the results from a build pre-revision and the test build (which is current trunk with the revision backed out, but that has other side effects)

Build with the revision in question: the damage is 18, always on all difficulties.

(0014691)
niffiwan   
2013-02-08 22:08   
(Last edited: 2013-02-08 22:11)
Aww... I just did that as well with Yarn's mission - well, not to let the results go to waste :)

No Mod active - Shivan Mega Laser firing at an Ursa

r8628
    very easy: 7.500000
    easy: 15.000000
    medium: 19.500000
    hard: 25.500000
    insane: 30.000000

r8629
    very easy: 30.000000
    easy: 30.000000
    medium: 30.000000
    hard: 30.000004
    insane: 30.000000

(also removed my test mission from the ticket)

Also note: the firing speed of the Basilisk did change, with hard & insane being noticeably faster than very easy / easy / medium

(0014692)
Woolie Wool   
2013-02-08 22:18   
(Last edited: 2013-02-08 22:53)
Confirmed that this actually isn't related to insane difficulty, but simply ignoring all damage scaling by difficulty.

I created a new AI profile called "LOL U R DED" with the damage factor on Insane set to 50000. Turrets still did 18% damage to the Apollo with newer builds.

In older builds, after correcting a stupid typo, a single ML-16 shot could kill the player in this profile on Insane in older builds. So it indeed has nothing to do with Insane but rather the complete absence of damage scaling.

Profile is:

$Profile name: LOL U R DED
$Player Damage Factor: 0.25, 0.5, 1, 1.5, 50000
#End

(0014693)
Yarn   
2013-02-08 22:44   
Woolie Wool, I think I know why that's happening: you entered 0.5 as 0,5, which the game interprets as two values instead of one. See what happens if you correct that.
(0014694)
Woolie Wool   
2013-02-08 22:52   
Corrected, see note edit above. Everything ran as expected, instant overkill in older builds, 18% damage in newer builds.
(0014695)
Zacam   
2013-02-08 23:01   
So, it's not that it cares about the difficulty level scaling, it's that it is getting some arbitrary value and using that regardless of the difficulty scaling.

That -should- make it easier to track down.
(0014696)
Woolie Wool   
2013-02-08 23:27   
The +Difficulty Scale Type: parameter in armor.tbl is also broken and does nothing.
(0014697)
The_E   
2013-02-09 18:33   
Attached a patch that may fix this. Please test.
(0014698)
niffiwan   
2013-02-09 22:37   
Patch appears to fix the damage scaling. Tested with Yarn's mission:

Very Easy -> Insane:
7.500000
15.000000
19.500000
25.500000
30.000000
(0014699)
The_E   
2013-02-10 04:36   
Patch committed to trunk in 9529. The issues with +Difficulty Scale Type: will be dealt with in Mantis 2793.

Issue History
2013-02-07 00:03Woolie WoolNew Issue
2013-02-07 00:07Woolie WoolNote Added: 0014686
2013-02-07 05:45niffiwanNote Added: 0014687
2013-02-07 05:45niffiwanAssigned To => niffiwan
2013-02-07 05:45niffiwanStatusnew => confirmed
2013-02-07 05:46niffiwanFile Added: hurtme.fs2
2013-02-07 05:47niffiwanNote Edited: 0014687bug_revision_view_page.php?bugnote_id=14687#r388
2013-02-07 05:47niffiwanAssigned Toniffiwan =>
2013-02-07 19:00YarnFile Added: WeaponDamageTest.fs2
2013-02-07 19:00YarnNote Added: 0014688
2013-02-08 19:00ZacamNote Added: 0014689
2013-02-08 22:05ZacamNote Edited: 0014689bug_revision_view_page.php?bugnote_id=14689#r390
2013-02-08 22:08niffiwanNote Added: 0014691
2013-02-08 22:08niffiwanFile Deleted: hurtme.fs2
2013-02-08 22:09niffiwanNote Edited: 0014691bug_revision_view_page.php?bugnote_id=14691#r392
2013-02-08 22:11niffiwanNote Edited: 0014691bug_revision_view_page.php?bugnote_id=14691#r393
2013-02-08 22:18Woolie WoolNote Added: 0014692
2013-02-08 22:19Woolie WoolNote Edited: 0014692bug_revision_view_page.php?bugnote_id=14692#r395
2013-02-08 22:27Woolie WoolNote Edited: 0014692bug_revision_view_page.php?bugnote_id=14692#r396
2013-02-08 22:44YarnNote Added: 0014693
2013-02-08 22:48Woolie WoolNote Edited: 0014692bug_revision_view_page.php?bugnote_id=14692#r397
2013-02-08 22:52Woolie WoolNote Added: 0014694
2013-02-08 22:53Woolie WoolNote Edited: 0014692bug_revision_view_page.php?bugnote_id=14692#r398
2013-02-08 23:01ZacamNote Added: 0014695
2013-02-08 23:27Woolie WoolNote Added: 0014696
2013-02-09 18:32The_EFile Added: 2788.patch
2013-02-09 18:33The_ENote Added: 0014697
2013-02-09 22:37niffiwanNote Added: 0014698
2013-02-10 04:36The_ENote Added: 0014699
2013-02-10 04:36The_EStatusconfirmed => resolved
2013-02-10 04:36The_EResolutionopen => fixed
2013-02-10 04:36The_EAssigned To => The_E