Source Code Project Mantis - FSSCP
View Issue Details
0002777FSSCPBuild systempublic2013-01-10 00:302013-01-13 04:13
Assigned To 
PrioritylowSeveritytweakReproducibilityhave not tried
Platformx86_64OSDebianOS Version7
Product Version3.6.14 
Target VersionFixed in Version 
Summary0002777: spelling corrections [patch]
Descriptioncorrect grammar with patch.
TagsNo tags attached.
Attached Filespatch spelling.patch (24,187) 2013-01-10 00:30
patch spelling[trunk].patch (26,295) 2013-01-13 03:17

2013-01-10 15:08   
the change to ship.cpp will break Ships.tbl, see

2013-01-10 15:34   
Yeah, that last one cannot go in. In fact I don't even know if any flag like that could support having an apostrophe. Rest of the patch looked fine though.
2013-01-12 17:06   
Looks good to me too. I went to commit the patch, sans the ship.cpp change, but almost every patch hunk was rejected. Onlyjob, could you generate a new patch?
2013-01-12 18:58   
Against the latest trunk, please.
2013-01-13 03:19   
Apologies for messing up with ship.cpp. I'll be more careful.

Please find revised patch for trunk attached. I hope it's better. Thanks.
2013-01-13 04:11   
It's not ship.cpp that's the problem, it's the fact that "dont collide invisible" is actually a flag that is parsed from a file. Don't worry; overall it's a good patch.

Unfortunately, this one was rejected again. I think I see why; you seem to have two separate folder structures under "a" and "b". Fortunately, by editing in Notepad, I was able to convert it so that it patched successfully.

Issue History
2013-01-10 00:30onlyjobNew Issue
2013-01-10 00:30onlyjobStatusnew => assigned
2013-01-10 00:30onlyjobAssigned To => chief1983
2013-01-10 00:30onlyjobFile Added: spelling.patch
2013-01-10 15:08Eli2Note Added: 0014625
2013-01-10 15:08Eli2Note Edited: 0014625bug_revision_view_page.php?bugnote_id=14625#r365
2013-01-10 15:34chief1983Note Added: 0014627
2013-01-10 15:50niffiwanStatusassigned => code review
2013-01-12 17:06Goober5000Note Added: 0014639
2013-01-12 18:58chief1983Note Added: 0014643
2013-01-13 03:17onlyjobFile Added: spelling[trunk].patch
2013-01-13 03:19onlyjobNote Added: 0014647
2013-01-13 04:11Goober5000Note Added: 0014648
2013-01-13 04:13Goober5000Changeset attached => fs2open trunk r9503
2013-01-13 04:13Goober5000Assigned Tochief1983 =>
2013-01-13 04:13Goober5000Statuscode review => resolved
2013-01-13 04:13Goober5000Resolutionopen => fixed