Source Code Project Mantis - FSSCP
View Issue Details
0002733FSSCPSEXPspublic2012-11-22 14:472012-12-12 08:27
Assigned ToThe_E 
PlatformOSOS Version
Product Version3.6.15 
Target VersionFixed in Version 
Summary0002733: Add-nav-waypoint 4th argument
DescriptionWell the first thing is that the 4th argument is undocumented. I found this while checking for sexps affected by 2048. As I have no idea what it's even trying to do I do not know what is should be doing with what is supplied in that 4th argument and if it should be applied to parse objects or wings that haven't arrived yet.
Steps To ReproduceSearch sexp.cpp for add_nav_waypoint and check the description in FRED (well I guess you could just check that in sexp.cpp as well)
TagsNo tags attached.
Attached Filespatch 2733.patch (1,639) 2012-12-10 12:47

2012-11-22 16:33   
Hoping Kazan is available to fill in help text for this...
2012-12-05 13:58   
Grabbing this because Kazan does not seem to be inclined to show up.

While I'm at it, I'm also going to rewrite the sexp help for ALL of his navpoint sexps, given that he didn't see fit to follow the established conventions AT ALL.
2012-12-05 15:44   
it's been so long i don't even have a code checkout of ANYTHING on my personal hardware. link me to a source browse of the file and i'll see if i can remember.
2012-12-05 17:41
2012-12-05 18:13   
I didn't add the fourth parameter.. but from code context and the diff that added it ( ) it appears to be related to making waypoints function in multiplayer the comment indicates that the fourth argument is "ShipWingTeam"

the change is Kara's
Revision 5598 - (view) (download) (as text) - [select for diffs]
Modified Tue Sep 15 13:47:38 2009 UTC (3 years, 2 months ago) by karajorma
2012-12-09 17:17   
Fix committed to trunk@9418.
2012-12-09 18:30   
Reopening this as while the fix addresses the description of the 4th argument we still don't know what it's supposed to be or how to handle it. For instance the sexp takes OPF_SHIP_WING_POINT as an argument but looks for OSWPT_TYPE_TEAM in the optional argument and does nothing(at best) if passed a point.

What we really need is to find someone that is actually using this to tell us what is is supposed to be doing.
2012-12-09 23:04   
Yeah, that little detail is why I went looking for Kazan... >.>

Though if Karajorma added that argument, he ought to be able to fill out the sexp help. Assigning to him.
2012-12-10 12:48   
Attached a patch that restores the intended behaviour (at least as far as I can tell what it should be).
2012-12-12 04:55   
The E seems to have a handle on what the fix should have done. The idea is that you can say the new nav point should only be visible to certain players, wings or teams.

I'll have a look in a bit and see if his patch solves the issue in a couple of hours.
2012-12-12 07:46   
Yeah, The_E's patch fixes the problem. I patched the code to solve the multiplayer issue and then no one ever got back to me on whether it worked or not. Which is why such poor code managed to survive that long.
2012-12-12 08:27   
Fix committed to svn in revision 9422

Issue History
2012-11-22 14:47FUBAR-BDHRNew Issue
2012-11-22 16:33Goober5000Note Added: 0014151
2012-11-22 16:33Goober5000Assigned To => Kazan
2012-11-22 16:33Goober5000Statusnew => assigned
2012-12-05 13:56The_EAssigned ToKazan => The_E
2012-12-05 13:58The_ENote Added: 0014311
2012-12-05 15:44KazanNote Added: 0014316
2012-12-05 17:41Goober5000Note Added: 0014319
2012-12-05 18:13KazanNote Added: 0014320
2012-12-09 17:17The_EChangeset attached => fs2open trunk r9418
2012-12-09 17:17The_ENote Added: 0014392
2012-12-09 17:17The_EStatusassigned => resolved
2012-12-09 17:17The_EResolutionopen => fixed
2012-12-09 18:30FUBAR-BDHRNote Added: 0014394
2012-12-09 18:30FUBAR-BDHRStatusresolved => feedback
2012-12-09 18:30FUBAR-BDHRResolutionfixed => reopened
2012-12-09 23:04Goober5000Note Added: 0014401
2012-12-09 23:04Goober5000Assigned ToThe_E => karajorma
2012-12-10 12:47The_EFile Added: 2733.patch
2012-12-10 12:48The_ENote Added: 0014410
2012-12-12 04:55karajormaNote Added: 0014426
2012-12-12 07:46karajormaNote Added: 0014427
2012-12-12 08:26The_EAssigned Tokarajorma => The_E
2012-12-12 08:26The_EStatusfeedback => assigned
2012-12-12 08:27The_ENote Added: 0014428
2012-12-12 08:27The_EStatusassigned => resolved
2012-12-12 08:27The_EResolutionreopened => fixed