Source Code Project Mantis - FSSCP
View Issue Details
0002678FSSCPFREDpublic2012-07-04 16:252012-07-23 23:03
Assigned ToGoober5000 
PlatformOSOS Version
Product Version3.6.14 RC5 
Target VersionFixed in Version 
Summary0002678: FRED can save coop missions that will crash on start
DescriptionFSO crashes with an

"ASSERTION: "Player_start_shipnum != -1" at missionparse.cpp:5279"

when trying to start a mission where a player wing has the +Arrival delay: property set. This is not a problem by itself since that property is entirely optional.

However, FRED automatically sets that property by default when you create a new wing, and the corresponding field (Delay XX seconds) is greyed out and uneditable for player wings. FRED will not raise any warning when saving.

This can only be solved by hand-editing the mission file.

It doesn't crash with a release build, but it opens an in-game pop-up : "server encountered errors trying to assign players to ships" and gets you back to the lobby.
Steps To Reproduce1) Open FRED
2) set mission specs to multiplayer - coop
3) select the player ship and create alpha wing
4) save and try to open the mission with a debug build
Additional InformationThe crash itself isn't really an issue. Ideally, however, FRED should be able to fix it itself when saving and/or send a warning when saving.
TagsNo tags attached.
Attached Files? ...CoopTest.fs2 (3,337) 2012-07-05 01:57

2012-07-04 17:41   
Your steps did not reproduce the problem for me. Can you test it again on the latest 3.6.14 branch build?
2012-07-05 01:56   
(Last edited: 2012-07-05 01:57)
Indeed. It seems those builds set Arrival delay to 0 by default. The problem can still happen if you do something like
1) create a new ship
2) put it in Alpha wing
3) add an arrival delay to alpha wing
3) set mission specs to coop
4) make alpha 1 the player ship

However it is more contrived and I doubt many people will hit it now.
I'm uploading a copy of a mission set up like this that crashes FSO at load. See files attached to the mantis report.

2012-07-13 01:04   
Fixed and tested on FRED and FSO.

Issue History
2012-07-04 16:25MatthTheGeekNew Issue
2012-07-04 17:41Goober5000Note Added: 0013824
2012-07-04 17:41Goober5000Assigned To => Goober5000
2012-07-04 17:41Goober5000Statusnew => feedback
2012-07-05 01:56MatthTheGeekNote Added: 0013829
2012-07-05 01:56MatthTheGeekStatusfeedback => assigned
2012-07-05 01:57MatthTheGeekFile Added: ...CoopTest.fs2
2012-07-05 01:57MatthTheGeekNote Edited: 0013829bug_revision_view_page.php?bugnote_id=13829#r185
2012-07-13 01:03Goober5000Changeset attached => fs2open trunk r9010
2012-07-13 01:04Goober5000Note Added: 0013855
2012-07-13 01:04Goober5000Statusassigned => resolved
2012-07-13 01:04Goober5000Resolutionopen => fixed
2012-07-23 23:03ZacamChangeset attached => fs2open fs2_open_3_6_14 r9041