Source Code Project Mantis - FSSCP
View Issue Details
0002666FSSCPHUDpublic2012-06-16 16:112012-07-01 21:25
ReporterYarn 
Assigned Toniffiwan 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Platformx64OSWindows 7OS Version
Product Version3.6.14 RC5 
Target VersionFixed in Version 
Summary0002666: Background for red-alert "downloading new orders..." message not positioned correctly in custom HUD layouts
DescriptionIf the "downloading new orders..." message appears and a custom HUD layout is being used, the background for that message (but not the text itself) will be positioned and scaled for a 1024x768 HUD, regardless of the current HUD's actual resolution.
Steps To Reproduce1) Make sure that a mod with a widescreen HUD (such as FSPort 3.3 with MediaVPs) is selected and that your game is configured for a widescreen resolution.

2) Play a mission that ends in red alert, such as one of the attached missions.

3) When the "downloading new orders..." message appears, notice where the message background is. It will probably be below and to the right of the message text.
Additional InformationThis problem also occurs in r8892 and RC6.
TagsNo tags attached.
Attached Files? RedAlertTestFSPort.fs2 (3,122) 2012-06-16 16:11
http://scp.indiegames.us/mantis/file_download.php?file_id=1866&type=bug
? RedAlertTestFS2.fs2 (3,364) 2012-06-16 16:12
http://scp.indiegames.us/mantis/file_download.php?file_id=1867&type=bug
jpg RedAlert.jpg (19,626) 2012-06-16 16:12
http://scp.indiegames.us/mantis/file_download.php?file_id=1868&type=bug
jpg

png ApplyError1.png (70,879) 2012-06-22 13:55
http://scp.indiegames.us/mantis/file_download.php?file_id=1881&type=bug
png

png ApplyError2.png (44,399) 2012-06-22 13:55
http://scp.indiegames.us/mantis/file_download.php?file_id=1882&type=bug
png

patch mantis2666.patch (551) 2012-06-22 19:05
http://scp.indiegames.us/mantis/file_download.php?file_id=1884&type=bug

Notes
(0013687)
niffiwan   
2012-06-21 02:44   
The attached patch has fixed the issue in my testing with your missions - could you also run some tests and let me know if this fixes it for you as well? Thanks
(0013694)
Yarn   
2012-06-21 14:52   
(Last edited: 2012-06-21 14:53)
I can't get your patch to apply. Could you make another one? I'm applying it as instructed here: http://www.hard-light.net/forums/index.php?topic=74840.msg1479356#msg1479356

(0013697)
niffiwan   
2012-06-21 19:17   
I think I know what was wrong with the patch - here's a new one.
(0013698)
Yarn   
2012-06-21 22:24   
I still can't apply your patch. I've applied FSO patches before; is this one supposed to be applied differently? (I'm trying to apply this to revision 8897, by the way.)
(0013699)
niffiwan   
2012-06-22 05:20   
Sorry about this (one of the pitfalls of using git instead of svn...) - please try this one. If it still doesn't work, please send me a screenshot of the error you get from TortoiseSVN. Oh, and also send me an example of a patch you've applied before so I can figure out what I'm doing wrong :)
(0013702)
Yarn   
2012-06-22 14:02   
Here are the errors that I get. The first error appeared only with your first and third attempts, but the second error appeared with all three.

As for what you're doing wrong, the only thing that I can think of is that you're saving the patch outside the fs2_open folder (or whatever your working folder is); it should be saved inside (but not in the subfolders).

I can't remember exactly what patches I've applied in the past, but the one posted to Mantis 0002657 works for me.
(0013703)
niffiwan   
2012-06-22 19:10   
fingers crossed - this one should work. You're right, my patches are made from one level higher than the "fs2_open" directory, my local git repository is a copy of everything at trunk (e.g. includes the fsoinstaller & Launcher) which has been causing me various issues. In this patch I've removed the extra directory from the path in the patch, which is what I did in the 2nd patch, however the 2nd patch had the wrong revision...
(0013704)
Yarn   
2012-06-22 20:28   
I figured out what the problem was: the patches that you uploaded had spaces instead of tabs in the third and fourth lines. Changing those allowed me to apply the patch.

Anyway, I tested your patch and it worked fine.
(0013706)
niffiwan   
2012-06-22 23:02   
Fix committed to trunk@8900.
(0013769)
Zacam   
2012-07-01 21:25   
Fix committed to fs2_open_3_6_14@8958.

Issue History
2012-06-16 16:11YarnNew Issue
2012-06-16 16:11YarnFile Added: RedAlertTestFSPort.fs2
2012-06-16 16:12YarnFile Added: RedAlertTestFS2.fs2
2012-06-16 16:12YarnFile Added: RedAlert.jpg
2012-06-21 02:41niffiwanAssigned To => niffiwan
2012-06-21 02:41niffiwanStatusnew => assigned
2012-06-21 02:41niffiwanFile Added: mantis-2666.patch
2012-06-21 02:44niffiwanNote Added: 0013687
2012-06-21 02:44niffiwanStatusassigned => feedback
2012-06-21 14:52YarnNote Added: 0013694
2012-06-21 14:52YarnStatusfeedback => assigned
2012-06-21 14:53YarnNote Edited: 0013694bug_revision_view_page.php?bugnote_id=13694#r159
2012-06-21 14:53YarnNote Edited: 0013694bug_revision_view_page.php?bugnote_id=13694#r160
2012-06-21 19:15niffiwanFile Deleted: mantis-2666.patch
2012-06-21 19:16niffiwanFile Added: mantis-2666.patch
2012-06-21 19:17niffiwanNote Added: 0013697
2012-06-21 19:17niffiwanStatusassigned => feedback
2012-06-21 22:24YarnNote Added: 0013698
2012-06-21 22:24YarnStatusfeedback => assigned
2012-06-22 05:12niffiwanFile Deleted: mantis-2666.patch
2012-06-22 05:12niffiwanFile Added: mantis2666.patch
2012-06-22 05:20niffiwanNote Added: 0013699
2012-06-22 05:20niffiwanStatusassigned => feedback
2012-06-22 13:55YarnFile Added: ApplyError1.png
2012-06-22 13:55YarnFile Added: ApplyError2.png
2012-06-22 14:02YarnNote Added: 0013702
2012-06-22 14:02YarnStatusfeedback => assigned
2012-06-22 18:57niffiwanFile Deleted: mantis2666.patch
2012-06-22 18:58niffiwanFile Added: mantis2666.patch
2012-06-22 19:05niffiwanFile Deleted: mantis2666.patch
2012-06-22 19:05niffiwanFile Added: mantis2666.patch
2012-06-22 19:10niffiwanNote Added: 0013703
2012-06-22 19:10niffiwanStatusassigned => feedback
2012-06-22 20:28YarnNote Added: 0013704
2012-06-22 20:28YarnStatusfeedback => assigned
2012-06-22 23:02niffiwanChangeset attached => fs2open trunk r8900
2012-06-22 23:02niffiwanNote Added: 0013706
2012-06-22 23:02niffiwanStatusassigned => resolved
2012-06-22 23:02niffiwanResolutionopen => fixed
2012-07-01 21:25ZacamChangeset attached => fs2open fs2_open_3_6_14 r8958
2012-07-01 21:25ZacamNote Added: 0013769