Source Code Project Mantis - FSSCP
View Issue Details
0002590FSSCPgameplaypublic2012-01-28 21:512012-07-24 06:06
Reporterniffiwan 
Assigned Toniffiwan 
PrioritynormalSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
PlatformallOSallOS Versionall
Product Version3.6.14 RC6 
Target Version3.6.14Fixed in Version3.6.14 
Summary0002590: Starting Wings are allowed to have 6 ships which causes crashes when restarting the mission
DescriptionThe wings in $Starting Wings: are allowed to have 6 ships. However the ship & loadout selection screens assume a maximum of 4 ships per wing. This causes issues with the loadout screen itself, as well as causes the mission to crash on restart.

A simple option would be to not allow missions with more than MAX_WING_SLOTS (4) ships in starting wings to parse. A more complicated option (& a feature) would be to increase MAX_WING_SLOTS to 6.
Steps To ReproduceGet clippingtest.fs2 from the RC4 release thread.
http://www.hard-light.net/forums/index.php?topic=79747.msg1579245#msg1579245
(or see attached to this

Open the mission in the simulator and switch to the ship selection screen.
Note that "Gamma Wing" only has two ships and one is locked.

Start the mission, press escape and select "restart mission". FSO will crash.
Additional InformationWe should provide an updated mission in the RC4 thread before we stop this mission from parsing. Otherwise we're shooting ourselves in the foot regarding testing of the new sound code.
TagsNo tags attached.
related to 0002653resolved karajorma MAX_WING_SLOTS warning is triggering on a wing of 4 ships. 
Attached Files? clippingtest.fs2 (17,351) 2012-01-28 21:51
http://scp.indiegames.us/mantis/file_download.php?file_id=1766&type=bug

Notes
(0013220)
niffiwan   
2012-02-01 04:22   
Fix committed to trunk@8413.
(0013309)
Zacam   
2012-02-13 19:48   
Fix committed to fs2_open_3_6_14@8484.
(0013565)
karajorma   
2012-05-18 22:27   
Fix committed to trunk@8795.
(0013760)
Zacam   
2012-07-01 21:01   
Fix committed to fs2_open_3_6_14@8936.
(0013832)
niffiwan   
2012-07-05 09:07   
I think that karajorma's fix has re-introduced the original bug :( This is a reminder for me to review this...
(0013882)
niffiwan   
2012-07-23 23:25   
derp - j will be out of bounds when slot is assigned after j has reached MAX_WING_SLOTS... needs another fix
(0013885)
niffiwan   
2012-07-24 06:06   
Should be fixed in r9052

Issue History
2012-01-28 21:51niffiwanNew Issue
2012-01-28 21:51niffiwanFile Added: clippingtest.fs2
2012-01-28 21:52niffiwanAssigned To => niffiwan
2012-01-28 21:52niffiwanStatusnew => assigned
2012-01-28 23:41niffiwanDescription Updatedbug_revision_view_page.php?rev_id=19#r19
2012-02-01 04:22niffiwanChangeset attached => fs2open trunk r8413
2012-02-01 04:22niffiwanNote Added: 0013220
2012-02-01 04:22niffiwanStatusassigned => resolved
2012-02-01 04:22niffiwanResolutionopen => fixed
2012-02-13 19:48ZacamChangeset attached => fs2open fs2_open_3_6_14 r8484
2012-02-13 19:48ZacamNote Added: 0013309
2012-05-18 22:27karajormaChangeset attached => fs2open trunk r8795
2012-05-18 22:27karajormaNote Added: 0013565
2012-07-01 21:01ZacamChangeset attached => fs2open fs2_open_3_6_14 r8936
2012-07-01 21:01ZacamNote Added: 0013760
2012-07-05 09:07niffiwanNote Added: 0013832
2012-07-05 09:07niffiwanStatusresolved => feedback
2012-07-05 09:07niffiwanResolutionfixed => reopened
2012-07-05 09:07niffiwanRelationship addedrelated to 0002653
2012-07-05 09:07niffiwanStatusfeedback => assigned
2012-07-06 21:37niffiwanChangeset attached => fs2open trunk r8995
2012-07-06 21:39niffiwanProduct Version3.6.14 RC4 => 3.6.14 RC6
2012-07-06 21:39niffiwanStatusassigned => resolved
2012-07-06 21:39niffiwanFixed in Version => 3.6.14
2012-07-06 21:39niffiwanResolutionreopened => fixed
2012-07-23 21:32ZacamChangeset attached => fs2open fs2_open_3_6_14 r9033
2012-07-23 23:25niffiwanNote Added: 0013882
2012-07-23 23:25niffiwanStatusresolved => feedback
2012-07-23 23:25niffiwanResolutionfixed => reopened
2012-07-24 06:06niffiwanNote Added: 0013885
2012-07-24 06:06niffiwanStatusfeedback => assigned
2012-07-24 06:06niffiwanStatusassigned => resolved
2012-07-24 06:06niffiwanResolutionreopened => fixed