Source Code Project Mantis - FSSCP
View Issue Details
0002520FSSCPPlatform-Engine interactionpublic2011-10-15 10:442011-10-16 02:12
ReporterComputerDruid 
Assigned ToEchelon9 
PrioritynormalSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version3.6.13 
Summary0002520: r7905 crashes when no -keyboard_layout is specified
Descriptionr7905 introduced the new -keyboard_layout option. However, when not specified, it causes strcmp to be called on a null pointer, which causes a segfault on my system/optimizations (Linux x86_64)
Additional InformationRecommend to first check if the option is specified before running strcmp.

Please see attached patch.
TagsNo tags attached.
Attached Filespatch fix-strcmp.patch (469) 2011-10-15 10:44
http://scp.indiegames.us/mantis/file_download.php?file_id=1721&type=bug

Notes
(0012893)
Echelon9   
2011-10-16 02:12   
Fixed in a similar, but not quite the same, way in http://svn.icculus.org/fs2open?view=rev&revision=7906

Issue History
2011-10-15 10:44ComputerDruidNew Issue
2011-10-15 10:44ComputerDruidFile Added: fix-strcmp.patch
2011-10-16 02:11Echelon9Statusnew => assigned
2011-10-16 02:11Echelon9Assigned To => Echelon9
2011-10-16 02:12Echelon9Note Added: 0012893
2011-10-16 02:12Echelon9Statusassigned => resolved
2011-10-16 02:12Echelon9Fixed in Version => 3.6.13
2011-10-16 02:12Echelon9Resolutionopen => fixed