Source Code Project Mantis - FSSCP
View Issue Details
0002470FSSCPtablespublic2011-07-12 00:532011-10-05 11:23
Reporterbigchunk1 
Assigned Toniffiwan 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.6.13 
Target VersionFixed in Version3.6.14 
Summary0002470: $Flags: ("untargetable") does not work on turret subsystems
DescriptionIf you have a turret subsystem on a ship and try to add the "untargetable" flag to it in the ships.tbl, the turret will remain targetable in game. The flag will not cause any errors or warnings in debug, but will fail to work on turrets.
Additional InformationI have included a test mod for this issue.
http://www.mediafire.com/?14h6gt6v5c4m4ky
TagsNo tags attached.
Attached Files? ufen-shp.tbm (11,291) 2011-10-03 06:40
http://scp.indiegames.us/mantis/file_download.php?file_id=1714&type=bug
? TestBC102.fs2 (5,321) 2011-10-03 06:40
http://scp.indiegames.us/mantis/file_download.php?file_id=1715&type=bug
patch mantis-2470.patch (868) 2011-10-03 06:42
http://scp.indiegames.us/mantis/file_download.php?file_id=1716&type=bug

Notes
(0012748)
Zacam   
2011-07-17 02:20   
I may be wrong here, but it doesn't help when the turret you are setting to "untargetable" also happens to be loaded with a weapon, as I'm pretty sure it was not meant to work that way.

AFAIR, "untargetable" (along with "damage as hull" "no aggregate" in conjunction) are to be used with -empty- turrets.
(0012763)
MjnMixael   
2011-08-12 19:53   
But there are cases where it's desirable to have an untargetable turret that still fires weapons. Case in point.. my Construction Drone..

If this is not a bug.. then could we get it as a feature/expansion of the current flag?
(0012775)
Goober5000   
2011-08-21 21:59   
I was the one who implemented "untargetable", and this was just an oversight. Even though turrets are subsystems, they're treated slightly differently than bog-standard subsystems.
(0012876)
niffiwan   
2011-10-03 06:39   
(Last edited: 2011-10-03 06:41)
Fix committed to trunk 7853

Note that the test mission triggers a different bug which I've mantised here:
http://scp.indiegames.us/mantis/view.php?id=2513

I used the attached files to test this issue was fixed, I just swapped the untargetable Fenris for an Aten.

When the patch arrives in a nightly, could you please test this with the new mission file & table?

Thanks

(0012877)
niffiwan   
2011-10-03 17:39   
Here's the windows nightly:
http://www.hard-light.net/forums/index.php?topic=78498.0
(0012878)
MjnMixael   
2011-10-03 22:42   
Tested and works as expected on my end.
(0012881)
niffiwan   
2011-10-05 06:30   
Thanks for testing MjnMixael
(0012882)
Goober5000   
2011-10-05 11:23   
Changed from closed to resolved, since that has been the de facto convention. (Fixed issues are resolved; issues that aren't fixed for whatever reason are closed.)

Issue History
2011-07-12 00:53bigchunk1New Issue
2011-07-17 02:20ZacamNote Added: 0012748
2011-08-12 19:53MjnMixaelNote Added: 0012763
2011-08-21 21:59Goober5000Note Added: 0012775
2011-10-02 00:23niffiwanStatusnew => assigned
2011-10-02 00:23niffiwanAssigned To => niffiwan
2011-10-03 06:39niffiwanNote Added: 0012876
2011-10-03 06:40niffiwanFile Added: ufen-shp.tbm
2011-10-03 06:40niffiwanFile Added: TestBC102.fs2
2011-10-03 06:40niffiwanStatusassigned => feedback
2011-10-03 06:41niffiwanNote Edited: 0012876
2011-10-03 06:41niffiwanNote Edited: 0012876
2011-10-03 06:42niffiwanFile Added: mantis-2470.patch
2011-10-03 17:39niffiwanNote Added: 0012877
2011-10-03 22:42MjnMixaelNote Added: 0012878
2011-10-05 06:30niffiwanNote Added: 0012881
2011-10-05 06:30niffiwanStatusfeedback => closed
2011-10-05 06:30niffiwanResolutionopen => fixed
2011-10-05 06:30niffiwanFixed in Version => 3.6.14
2011-10-05 11:23Goober5000Note Added: 0012882
2011-10-05 11:23Goober5000Statusclosed => resolved