Source Code Project Mantis - FSSCP
View Issue Details
0002185FSSCPtablespublic2010-04-19 14:502010-04-20 00:37
ReporterThe_E 
Assigned ToGoober5000 
PriorityimmediateSeverityblockReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.6.12 RC2 
Target VersionFixed in Version 
Summary0002185: Retail weapons.tbl parsing BROKEN after commit 6067
DescriptionLoading retail data fails with a recent (post-revision 6067) trunk build, with the following error:

weapons.tbl(line 887:
Error: Required token = [#End] or [$Name:], found [BeamSound: 115 ]
in weapon: @Targeting Laser
.

ntdll.dll! ZwWaitForSingleObject + 21 bytes
kernel32.dll! WaitForSingleObjectEx + 67 bytes
kernel32.dll! WaitForSingleObject + 18 bytes
fs2_open_3_6_13d.exe! SCP_DumpStack + 354 bytes
fs2_open_3_6_13d.exe! Error + 229 bytes
fs2_open_3_6_13d.exe! error_display + 427 bytes
fs2_open_3_6_13d.exe! required_string_either + 240 bytes
fs2_open_3_6_13d.exe! parse_weaponstbl + 150 bytes
fs2_open_3_6_13d.exe! weapon_init + 79 bytes
fs2_open_3_6_13d.exe! game_init + 1812 bytes
fs2_open_3_6_13d.exe! game_main + 519 bytes
fs2_open_3_6_13d.exe! WinMain + 330 bytes
fs2_open_3_6_13d.exe! __tmainCRTStartup + 322 bytes
fs2_open_3_6_13d.exe! WinMainCRTStartup + 15 bytes
kernel32.dll! BaseThreadInitThunk + 18 bytes
ntdll.dll! RtlInitializeExceptionChain + 99 bytes
ntdll.dll! RtlInitializeExceptionChain + 54 bytes

Testing with a pre-6067 build yields no such error.
To illustrate the issue, compare the two attached debug logs, especially at around line 8028 for both logs (Yes, they were both generated with +parse, so beware). The post-6067 build seems to see a 0 where there was none before.
TagsNo tags attached.
Attached Fileslog fs2_open pre 6067.log (852,901) 2010-04-19 14:50
http://scp.indiegames.us/mantis/file_download.php?file_id=1482&type=bug
log fs2_open post 6067.log (219,513) 2010-04-19 14:51
http://scp.indiegames.us/mantis/file_download.php?file_id=1483&type=bug

Notes
(0011896)
Goober5000   
2010-04-20 00:37   
Fixed in 6070. I was careless. :sigh:

Issue History
2010-04-19 14:50The_ENew Issue
2010-04-19 14:50The_EFile Added: fs2_open pre 6067.log
2010-04-19 14:51The_EFile Added: fs2_open post 6067.log
2010-04-19 14:54The_EStatusnew => assigned
2010-04-19 14:54The_EAssigned To => Goober5000
2010-04-20 00:37Goober5000Note Added: 0011896
2010-04-20 00:37Goober5000Statusassigned => resolved
2010-04-20 00:37Goober5000Resolutionopen => fixed
2010-04-20 00:37Goober5000Fixed in Version => 3.6.12
2010-04-20 00:37Goober5000Fixed in Version3.6.12 =>