Source Code Project Mantis - FSSCP
View Issue Details
0002156FSSCPPlatform-Engine interactionpublic2010-03-19 19:502010-03-19 20:21
ReporterEchelon9 
Assigned ToEchelon9 
PrioritynormalSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.6.12 RC1 
Target VersionFixed in Version3.6.12 RC2 
Summary0002156: Crash within outwnd_printf2(char*, ...) on non-Windows platforms
DescriptionA reproducible crash, caused by the engine overwriting a stack buffer in logging functions in outwnd_unix.cpp. Caused by vsprintf().

Issue found while developing Diaspora.
TagsNo tags attached.
Attached Filespatch fix-for-mantis-2156.patch (1,059) 2010-03-19 19:51
http://scp.indiegames.us/mantis/file_download.php?file_id=1451&type=bug

Notes
(0011805)
taylor   
2010-03-19 20:15   
I thought this had already been changed? May not have ever hit SVN I guess.

Anyway, there really isn't a need for the comments in that patch, otherwise it is good. I believe that there is another instance of vsprintf in that same file; don't suppose you could get that one too in an updated patch?
(0011806)
Echelon9   
2010-03-19 20:18   
It was changed in the Windows version of outwnd.cpp, just not in outwnd_unix.cpp

I'll update the other use of vsprintf() to vsnprintf() in that file.
(0011807)
Echelon9   
2010-03-19 20:21   
Fixed in r6023

Issue History
2010-03-19 19:50Echelon9New Issue
2010-03-19 19:50Echelon9Statusnew => assigned
2010-03-19 19:50Echelon9Assigned To => Echelon9
2010-03-19 19:51Echelon9File Added: fix-for-mantis-2156.patch
2010-03-19 19:51Echelon9Statusassigned => confirmed
2010-03-19 20:15taylorNote Added: 0011805
2010-03-19 20:18Echelon9Note Added: 0011806
2010-03-19 20:21Echelon9Note Added: 0011807
2010-03-19 20:21Echelon9Statusconfirmed => resolved
2010-03-19 20:21Echelon9Fixed in Version => 3.6.12 RC2
2010-03-19 20:21Echelon9Resolutionopen => fixed