Source Code Project Mantis - FSSCP
View Issue Details
0002092FSSCPgraphicspublic2010-01-15 00:152010-03-10 05:36
Reporterblowfish 
Assigned Totaylor 
PrioritynormalSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.6.11 
Target VersionFixed in Version3.6.12 RC2 
Summary0002092: FSO will crash if no post-processing shaders are found when -post_process is enabled.
DescriptionIf the shaders necessary for post-processing are not present when the launcher flag is enabled, FSO will crash when you start a mission (when you click the commit button).
Additional InformationRelevant lines of fs2_open.log:

  Compiling special shader -> post-v.sdr / brightpass-f.sdr ...
Could not open text file 'post-v.sdr'.
Could not open text file 'brightpass-f.sdr'.
Vertex shader failed to compile:
ERROR: Parser found no code to compile in source strings.

ERROR! Unable to create vertex shader!
ASSERTION: "image" at gropenglpostprocessing.cpp:46
TagsNo tags attached.
has duplicate 0002093closed Hery Exe ungracefully fails if -post_process is on, but shaders are not present 
Attached Files

Notes
(0011522)
blowfish   
2010-01-15 00:20   
Also the crash doesn't happen when -no_glsl is enabled, if that matters.
(0011526)
Hery   
2010-01-15 15:17   
This build should solve the problem: http://quarnos.org/dl/fso_2092_fix.zip
(0011527)
Zacam   
2010-01-15 20:02   
(Last edited: 2010-01-15 20:03)
Compiling special shader -> post-v.sdr / brightpass-f.sdr ...
Could not open text file 'post-v.sdr'.
Could not open text file 'brightpass-f.sdr'.
Vertex shader failed to compile:
(0) : error C0000: syntax error, unexpected $end at token "<EOF>"
(0) : error C0501: type name expected at token "<null atom>"

ERROR! Unable to create vertex shader!
Post-processing disabled.

It does indeed, though the error C00000 and error C0501 have me concerned.

Though, a .patch would have been easier to distribute the testing of the fix on multiple platforms a lot easier, as I con only confirm that on windows, this executable does not have the reported problem.

(0011555)
Hery   
2010-01-21 11:06   
There is no check whether a shader file exist, since if it doesn't compilation will fail anyway and the post-processing will be disabled. However, I think that it will be much more elegant to do that test for file existance, since now debug log may be a bit misleading. I'll do that as soon as I have more time for SCP and that, unfortunately, means after February 8th.
(0011762)
taylor   
2010-03-10 05:36   
Fixered.

Issue History
2010-01-15 00:15blowfishNew Issue
2010-01-15 00:20blowfishNote Added: 0011522
2010-01-15 08:29HeryStatusnew => assigned
2010-01-15 08:29HeryAssigned To => Hery
2010-01-15 14:28ZacamRelationship addedhas duplicate 0002093
2010-01-15 15:17HeryNote Added: 0011526
2010-01-15 20:02ZacamNote Added: 0011527
2010-01-15 20:03ZacamNote Edited: 0011527
2010-01-21 11:06HeryNote Added: 0011555
2010-03-10 05:36taylorNote Added: 0011762
2010-03-10 05:36taylorStatusassigned => resolved
2010-03-10 05:36taylorFixed in Version => 3.6.12 RC2
2010-03-10 05:36taylorResolutionopen => fixed
2010-03-10 05:36taylorStatusresolved => assigned
2010-03-10 05:36taylorAssigned ToHery => taylor
2010-03-10 05:36taylorStatusassigned => resolved