Source Code Project Mantis - FSSCP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001922FSSCPgraphicspublic2009-05-04 14:412012-12-05 03:34
ReporterSushi_CW 
Assigned Toniffiwan 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.6.9 
Target VersionFixed in Version3.6.15 
Summary0001922: Glowmaps not applied for target preview window
DescriptionAs in the title, texture replacement doesn't seem to be applied in the target preview window. I noticed this when playing Derelict in all of the missions where the Nyarlathotep is visible but hasn't yet come to life: although it looks black in the main game screen, the mini target-preview window in the bottom left shows the normal red Lucifer textures.

Not a huge issue, but it does break some of the immersion.
Additional InformationUsing 3.6.10 RC1, MediaVPs 3.6.10
TagsNo tags attached.
Relationships
Attached Files? dl2-11.fs2 (98,150) 2011-01-15 23:49
http://scp.indiegames.us/mantis/file_download.php?file_id=1632&type=bug
? dl2-11-festive.fs2 (98,459) 2012-12-03 05:16
http://scp.indiegames.us/mantis/file_download.php?file_id=2006&type=bug
patch mantis1922.svn.patch (760) 2012-12-04 05:19
http://scp.indiegames.us/mantis/file_download.php?file_id=2012&type=bug

Notes
(0010867)
Goober5000   
2009-05-04 15:25   
That's not texture replacement, that's glow mapping.

Valid question though.
(0012599)
Echelon9   
2011-01-15 03:09   
Can we get a means of reproducing with retail data?
(0012600)
Goober5000   
2011-01-15 03:22   
(Last edited: 2011-01-15 03:23)
That's not possible because this problem only shows up with a model that has glowmapping. So you'd need the mediavps at very least.

I don't think that Derelict mission includes any custom ships; you could probably extract it and test it without having the Derelict mod active.
(0012601)
Echelon9   
2011-01-15 04:17   
Here "retail" = standard campaign with mediavps. Much clearer now.

I don't have Derelict, and didn't want to download, setup and test if there's a quicker way to repro.
(0012602)
Goober5000   
2011-01-15 23:50   
I've uploaded the mission where the Nyarlathotep "comes to life". The only non-retail ship in that mission is the GTFf Saphah, but you can swap the Iceni for that.
(0014269)
niffiwan   
2012-12-03 05:21   
Updated mission with Iceni replacing Saphah and a couple of events to activate/deactive glowmaps for easier testing.

I've got a potential fix by setting MR_NO_GLOWMAPS in hud/hudtargetbox.cpp - but given there's already code to set MR_NO_GLOWMAPS in model/modelinterp.cpp model_really_render() I just want to do a bit more checking before posting the patch.
(0014284)
niffiwan   
2012-12-04 05:28   
See attached patch - tested successfully with the attached mission(s).
(0014290)
MjnMixael   
2012-12-04 14:00   
Tested successfully here too.
(0014293)
Valathil   
2012-12-04 18:07   
Looks good throw it in.
(0014303)
niffiwan   
2012-12-05 03:34   
Thanks for the review & testing. Committed in r9398

Issue History
Date ModifiedUsernameFieldChange
2009-05-04 14:41Sushi_CWNew Issue
2009-05-04 15:25Goober5000Note Added: 0010867
2011-01-15 03:09Echelon9Note Added: 0012599
2011-01-15 03:22Goober5000Note Added: 0012600
2011-01-15 03:23Goober5000Note Edited: 0012600
2011-01-15 03:23Goober5000Note Edited: 0012600
2011-01-15 04:17Echelon9Note Added: 0012601
2011-01-15 23:49Goober5000File Added: dl2-11.fs2
2011-01-15 23:50Goober5000Note Added: 0012602
2012-12-03 05:15niffiwanAssigned To => niffiwan
2012-12-03 05:15niffiwanStatusnew => assigned
2012-12-03 05:15niffiwanSummaryTexture Replacement not applied for target preview window => Glowmaps not applied for target preview window
2012-12-03 05:16niffiwanFile Added: dl2-11-festive.fs2
2012-12-03 05:21niffiwanNote Added: 0014269
2012-12-04 05:19niffiwanFile Added: mantis1922.svn.patch
2012-12-04 05:28niffiwanNote Added: 0014284
2012-12-04 05:28niffiwanStatusassigned => code review
2012-12-04 14:00MjnMixaelNote Added: 0014290
2012-12-04 18:07ValathilNote Added: 0014293
2012-12-05 03:34niffiwanNote Added: 0014303
2012-12-05 03:34niffiwanStatuscode review => resolved
2012-12-05 03:34niffiwanFixed in Version => 3.6.15
2012-12-05 03:34niffiwanResolutionopen => fixed