Source Code Project Mantis - FSSCP
View Issue Details
0000184FSSCPHT&Lpublic2004-05-11 16:202012-12-09 16:20
ReporterJarC 
Assigned ToValathil 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0000184: HTL: Engine/Thruster Ani's not scaled properly
DescriptionThis is a very old one I believe, I vaguely remember this being discussed before either on HLP or the FDL...
Anyways, here goes, screenies still the best to show what I mean so they're attached too. 1 for each throttle preset...

The thruster ani's are not always properly scaled for the various thruster presets (0, 1/3rd, 2/3rd, full). They are scaled relative to a point within the thruster cone, this makes the base of the ani rise as much from the engine plane as the length of the thruster shortens with respect to the chosen preset...
Additional InformationFrom Goober5000: The description may be a little unclear, so perhaps this will help: just take a look at the gap between the thruster flame and the body of the fighter, and compare the gap across all pictures.
TagsNo tags attached.
Attached Filesjpg thrust0.jpg (16,186) 2004-05-11 16:20
http://scp.indiegames.us/mantis/file_download.php?file_id=76&type=bug
jpg

jpg thrust1.jpg (14,111) 2004-05-11 16:22
http://scp.indiegames.us/mantis/file_download.php?file_id=77&type=bug
jpg

jpg thrust2.jpg (15,296) 2004-05-11 16:22
http://scp.indiegames.us/mantis/file_download.php?file_id=78&type=bug
jpg

jpg thrust3.jpg (16,148) 2004-05-11 16:22
http://scp.indiegames.us/mantis/file_download.php?file_id=79&type=bug
jpg

? thrustertest.fs2 (3,097) 2012-12-07 13:06
http://scp.indiegames.us/mantis/file_download.php?file_id=2026&type=bug
patch 184.patch (7,640) 2012-12-09 15:19
http://scp.indiegames.us/mantis/file_download.php?file_id=2037&type=bug

Notes
(0000936)
JarC   
2004-05-11 16:23   
shoot, completely forgot to select the correct dropdown values, this is ofcourse not a directx feature req, but a minor graphics bug...
(0000937)
Lightspeed   
2004-05-11 18:17   
I've noticed that, too.
(0000938)
RandomTiger   
2004-05-13 15:48   
You have logged this as a DX bug.
Does this mean it doesnt happen in OGL?
(0001909)
Bobboau   
2005-03-14 17:42   
it's a generic HT&L bug, we have no way of doing this the way V did untill we get vertex shaders. once we get that we should be able to fix this problem easily.
(0001964)
kasperl   
2005-03-15 11:58   
Updated category.
(0005518)
taylor   
2006-05-13 16:44   
Changing category to HT&L and un-assigning from Bobboau since he's not likely to ever fix this.
(0007036)
taylor   
2006-10-28 19:30   
Guess I might as well put this one on me as well. ;(
(0009450)
taylor   
2008-07-17 12:25   
Not going to work on this.
(0014345)
The_E   
2012-12-07 09:45   
*bump*

So this is still open?

Obvious question, does it need to be?
(0014349)
MjnMixael   
2012-12-07 13:05   
Yes, this is still a problem. Test mission attached.
(0014350)
Goober5000   
2012-12-07 13:06   
MjnMixael confirmed this is still an issue. Assigning to Valathil to see what can be done about it.
(0014385)
Valathil   
2012-12-09 13:37   
Attached patch with fix please review and test
(0014386)
MjnMixael   
2012-12-09 13:54   
Tested fixed. Note: the Pegasus still has a small bit of space between the thrusters and the hull. I checked the retail model and that is a model problem which was likely present in retail. The thruster cone mesh is not flush against the hull mesh.
(0014387)
Valathil   
2012-12-09 15:20   
Reuploaded patch with a crash fix for a hackish shader state buffering.
(0014390)
Valathil   
2012-12-09 16:20   
Fix committed to trunk@9416.

Issue History
2004-05-11 16:20JarCNew Issue
2004-05-11 16:20JarCFile Added: thrust0.jpg
2004-05-11 16:22JarCFile Added: thrust1.jpg
2004-05-11 16:22JarCFile Added: thrust2.jpg
2004-05-11 16:22JarCFile Added: thrust3.jpg
2004-05-11 16:23JarCNote Added: 0000936
2004-05-11 18:17LightspeedNote Added: 0000937
2004-05-13 15:48RandomTigerNote Added: 0000938
2004-05-13 15:48RandomTigerSeverityfeature => major
2004-05-13 15:48RandomTigerStatusnew => acknowledged
2004-05-13 15:48RandomTigerSummaryEngine/Thruster Ani's not scaled properly => HTL: Engine/Thruster Ani's not scaled properly
2005-03-14 08:38administratorAssigned To => Bobboau
2005-03-14 17:42BobboauNote Added: 0001909
2005-03-15 11:58kasperlNote Added: 0001964
2005-03-15 11:58kasperlSeveritymajor => minor
2005-03-15 11:58kasperlCategoryDirectX => graphics
2006-05-13 16:44taylorNote Added: 0005518
2006-05-13 16:44taylorAssigned ToBobboau =>
2006-05-13 16:44taylorCategorygraphics => HT&L
2006-10-28 19:30taylorNote Added: 0007036
2006-10-28 19:30taylorAssigned To => taylor
2006-10-28 19:30taylorStatusacknowledged => confirmed
2008-07-17 12:25taylorNote Added: 0009450
2008-07-17 12:25taylorAssigned Totaylor =>
2009-11-10 11:54ZacamStatusconfirmed => assigned
2009-11-10 11:54ZacamAssigned To => Zacam
2012-12-07 09:45The_ENote Added: 0014345
2012-12-07 13:05MjnMixaelNote Added: 0014349
2012-12-07 13:06MjnMixaelFile Added: thrustertest.fs2
2012-12-07 13:06Goober5000Note Added: 0014350
2012-12-07 13:06Goober5000Assigned ToZacam => Valathil
2012-12-07 13:08Goober5000Additional Information Updatedbug_revision_view_page.php?rev_id=288#r288
2012-12-09 13:37ValathilNote Added: 0014385
2012-12-09 13:37ValathilStatusassigned => code review
2012-12-09 13:37ValathilFile Added: 184.patch
2012-12-09 13:54MjnMixaelNote Added: 0014386
2012-12-09 15:19ValathilFile Deleted: 184.patch
2012-12-09 15:19ValathilFile Added: 184.patch
2012-12-09 15:20ValathilNote Added: 0014387
2012-12-09 16:20ValathilChangeset attached => fs2open trunk r9416
2012-12-09 16:20ValathilNote Added: 0014390
2012-12-09 16:20ValathilStatuscode review => resolved
2012-12-09 16:20ValathilResolutionopen => fixed