Source Code Project Mantis - FSSCP
View Issue Details
0001826FSSCPmultiplayerpublic2008-11-20 16:272015-12-19 18:05
ReporterFUBAR-BDHR 
Assigned To 
PrioritylowSeveritytextReproducibilityalways
StatusnewResolutionopen 
PlatformOSOS Version
Product Version3.6.9 
Target VersionFixed in Version 
Summary0001826: Switching to campaign mode doesn't update mission description
DescriptionIf you switch to campaign mode and there is a non coop mission selected the description will not update to the coop missions in the campaign.
Additional Information3.6.10 11/09 build. Screenshot coming soon.
TagsNo tags attached.
Attached Filesjpg campaign.jpg (95,827) 2008-11-20 18:11
http://scp.indiegames.us/mantis/file_download.php?file_id=1152&type=bug
jpg

Notes
(0010244)
FUBAR-BDHR   
2008-11-20 18:27   
Was in a bit of a hurry when I posted (hosting) and forgot to mention the host side updates find so it's a client side only thing.
(0016700)
Cyborg17   
2015-05-09 13:31   
(Last edited: 2015-05-09 13:32)
I've started looking at this issue, and I would like to see if I can try to solve it since it's sufficiently minor and would be a good project for me as I continue to try to understand the code and C++ better.

Problem still occurs in the most recent nightly. I'm able to test it on one computer by forcing different ports on multiple instances of the launcher for the same build.

(0016705)
Cyborg17   
2015-05-15 13:58   
Update on my progress:

This feature was never implemented into the engine, probably because it was not that useful a feature, and (I think) requires a new function or edits to an existing function. The logic for requesting the description is in place, but the function was not written in because the function is only able to send information on the current mission. I'm still game for trying it for now. I might jump on IRC for assistance.
(0016712)
Cyborg17   
2015-05-20 03:16   
I think I got it! I have the description field updating for campaign files. Only the host's exe needs to be updated as well, actually. The only issues might be with how I accomplished it. The Netgame_Info class has two new entries which aren't carried by the function which used to send the whole class. One of the entries is an int, acting as a boolean, which will tell you if the host is trying to select campaign or non-campaign games. So, a *little* disorganized, but I added good comments. You guys may want me to rearrange it to be a little cleaner. Like with a new class or something.

And now I'm in the odd position of not knowing how to post a patch file to share the proposed fix with. Would anyone be able to send me in the right direction? Should I just get on Github and try from there or should I try posting a patch here?
(0016714)
Cyborg17   
2015-05-20 20:26   
Pull request has been added to GIT. :)
(0016745)
Cyborg17   
2015-05-31 22:28   
File was too large to upload directly. So I have a mediafire link:

http://www.mediafire.com/download/xncrt05fvgmlfkd/fs2_open_3_7_3_AVXMANTIS1826CANDIDATE.7z
(0016804)
Goober5000   
2015-12-19 18:04   
(Last edited: 2015-12-19 18:05)
A github link would be nice to have. :p

Searching git yields four PRs, all closed:
https://github.com/scp-fs2open/fs2open.github.com/pull/122
https://github.com/scp-fs2open/fs2open.github.com/pull/189
https://github.com/scp-fs2open/fs2open.github.com/pull/190
https://github.com/scp-fs2open/fs2open.github.com/pull/191

Has there been any progress on a new PR?


Issue History
2008-11-20 16:27FUBAR-BDHRNew Issue
2008-11-20 18:11FUBAR-BDHRFile Added: campaign.jpg
2008-11-20 18:27FUBAR-BDHRNote Added: 0010244
2012-01-22 02:03Echelon9Prioritynormal => low
2012-01-22 02:03Echelon9SummarySwitching to campaing mode doesn't update mission description => Switching to campaign mode doesn't update mission description
2015-05-09 13:31Cyborg17Note Added: 0016700
2015-05-09 13:32Cyborg17Note Edited: 0016700bug_revision_view_page.php?bugnote_id=16700#r1048
2015-05-15 13:58Cyborg17Note Added: 0016705
2015-05-20 03:16Cyborg17Note Added: 0016712
2015-05-20 20:26Cyborg17Note Added: 0016714
2015-05-31 22:28Cyborg17Note Added: 0016745
2015-12-19 18:04Goober5000Note Added: 0016804
2015-12-19 18:05Goober5000Note Edited: 0016804bug_revision_view_page.php?bugnote_id=16804#r1064