View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002907 | FSSCP | gameplay | public | 2013-08-06 10:21 | 2014-06-11 09:36 |
| Reporter | niffiwan | Assigned To | niffiwan | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.7.0 RC2 | ||||
| Target Version | 3.7.2 | ||||
| Summary | 0002907: Unexpected behaviour in Red Alert missions when secondary bank is empty | ||||
| Description | If a pilot finishes the 1st mission with an empty secondary bank, in the next mission the bank will either be refilled or removed entirely from the ship. The result depends on the contents of the +Weaponry Pool in the 2nd mission. If the secondary exists, all available missiles will be loaded up to the normal capacity of the fighters bank. If the secondary does not exist, the bank will be removed. i.e. HUD looks like the ship has one less bank than normal. I'd expect the behaviour to be that bank remains empty but still available in the 2nd mission. | ||||
| Steps To Reproduce | Use BluePlanet Mod Play Universal Truth/Journey's End (bp-21 & bp-22) Select secondary weapons NOT in the list below, e.g. Trebuchets +Weaponry Pool: ( "Subach HL-7" 8 "Prometheus R" 8 "Prometheus S" 20 "Balor" 16 "Hornet" 244 "Tornado" 549 "Harpoon" 208 ) During Universal Truth empty the Trebs bank In Journey's End observe that the Trebs bank is now missing Optionally, add different numbers of Trebs to the +Weaponry Pool and observe how the bank now fills up, partially or fully depending on how many missiles where made available. | ||||
| Additional Information | This is probably a good place to start looking for a solution: missionui/missionweaponchoice.cpp : wl_remove_weps_from_pool() | ||||
| Tags | No tags attached. | ||||
|
|
Hmmm. So far unable to reproduce the issue on r9747 in FSPort sm2-05a & sm3-08a. Ditto for Freespace2 sm3-09. Maybe it's something to do with BP builds or just that mission? (and ditto for str02) (and for bp-04. It seems like bp-21/22 is the only mission with this problem!) |
|
|
Using the old Blueplanet release I've tested 3.6.18 & it has the same problem. |
|
|
Getting closer to finding the cause, it's something to do with red-alert + the mission flags set in the 2nd mission... And this seems to be the problematic flag: MISSION_FLAG_NO_BRIEFING |
|
|
mantis2907-svn.patch (401 bytes)
Index: code/missionui/redalert.cpp
===================================================================
--- code/missionui/redalert.cpp (revision 9750)
+++ code/missionui/redalert.cpp (working copy)
@@ -391,7 +391,7 @@
if (!(Game_mode & GM_MULTIPLAYER)) {
if (The_mission.flags & MISSION_FLAG_NO_BRIEFING)
{
- commit_pressed();
+ red_alert_button_pressed(RA_CONTINUE);
return;
}
}
|
|
|
Attached patch has been tested with a simple red alert mission & bp-21/bp-22. It's a simple fix. In red alert missions that skip the briefing, follow the same logic as if the normal red alert "accept" button had been pressed, not the ship/weapon select "commit" button. (will commit after 3.7.0 final) |
|
|
Fix committed to trunk@9764. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-08-06 10:21 | niffiwan | New Issue | |
| 2013-08-14 02:29 | niffiwan | Note Added: 0015234 | |
| 2013-08-14 02:44 | niffiwan | Note Edited: 0015234 | |
| 2013-08-14 09:35 | niffiwan | Note Edited: 0015234 | |
| 2013-08-15 08:57 | niffiwan | Note Edited: 0015234 | |
| 2013-08-15 08:58 | niffiwan | Note Edited: 0015234 | |
| 2013-08-21 08:34 | niffiwan | Note Added: 0015242 | |
| 2013-08-27 08:46 | niffiwan | Note Added: 0015243 | |
| 2013-08-28 08:25 | niffiwan | Note Edited: 0015243 | |
| 2013-08-29 08:46 | niffiwan | Assigned To | => niffiwan |
| 2013-08-29 08:46 | niffiwan | Status | new => assigned |
| 2013-08-29 08:46 | niffiwan | File Added: mantis2907-svn.patch | |
| 2013-08-29 08:49 | niffiwan | Note Added: 0015249 | |
| 2013-08-29 08:49 | niffiwan | Status | assigned => code review |
| 2013-09-02 07:24 | niffiwan | Changeset attached | => fs2open trunk r9764 |
| 2013-09-02 07:24 | niffiwan | Note Added: 0015258 | |
| 2013-09-02 07:24 | niffiwan | Status | code review => resolved |
| 2013-09-02 07:24 | niffiwan | Resolution | open => fixed |
| 2014-06-11 09:36 | niffiwan | Relationship added | related to 0003056 |
