View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002337 | FSSCP | SEXPs | public | 2010-11-13 15:11 | 2010-12-09 23:30 |
| Reporter | TopAce | Assigned To | FUBAR-BDHR | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.13 | ||||
| Fixed in Version | 3.6.13 | ||||
| Summary | 0002337: lock-rotating-subsystem affects more than it should | ||||
| Description | The lock-rotating-subsystem SEXP affects an entire class, not just the single ship that's set in the mission event. Tried it with Mjolnirs, Levs, and Anukets. See the attached test mission. Note that there's an Anuket as well, but only the Mjolnirs' subsystem rotation stops. | ||||
| Additional Information | Tried 3.6.13 nightlies, see this thread http://www.hard-light.net/forums/index.php?topic=72610.0 for fs log. | ||||
| Tags | No tags attached. | ||||
|
2010-11-13 15:11
|
|
|
|
Eugh. This has actually been around ever since the sexps were first added, except nobody noticed it because it was only used for a Knossos or an installation or something where only one ship appeared in a mission. There will need to be flags added to the ship-specific model instances in order to change the rotation as-needed. (This includes the sexps that change the rotation speed too.) |
|
|
I can probably take a look at that in a few days unless someone beats me to it. Sound's like the data is either not being copied to the ship or it is and the code is looking at the model or ship_info when it shouldn't. I think I've seen this before as well but as I was experimenting with things you shouldn't do or already broke the code I never bothered to check why. |
|
|
Also noted that if you disable the Mjolnirs' via lock-rotating-subsystem and then restart the mission using the "Esc" menu, they will be disabled when the mission restarts. |
|
|
Patch: http://fubar5.fubar.org/fs2netd/mantis2337-rotationfix.patch Test mission: http://fubar5.fubar.org/fs2netd/0rotate.fs2 SSE2 builds: http://fubar5.fubar.org/fs2netd/FS2_Open_2337fix.rar |
|
|
Looks good. |
|
|
But how's it sound? Goob brought up that question and I had the music on too loud to notice. |
|
|
As Goob thought, rotation sounds are still active after locking.... |
|
|
Yea figured it was a bit too easy. I'll take another look tomorrow. I just hope it's not tied into the ship_subsys->submodel_info_1 area. If so I have a feeling things are going to get really messy trying to figure out what should come from the model, ship_info and from the ship. |
|
|
I can not reproduce the sound issue. Works just fine. I updated the test mission with the ships farther apart and you now have to hit L to trigger the events. You will also need to modify the Faustus table entry with $RotationSnd: 185 on the science01a-solar1 subsystem. |
|
|
Fixed in revision 6820 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-11-13 15:11 | TopAce | New Issue | |
| 2010-11-13 15:11 | TopAce | File Added: lockrotsubsystem.fs2 | |
| 2010-11-14 02:16 | Goober5000 | Note Added: 0012460 | |
| 2010-11-14 02:16 | Goober5000 | Note Edited: 0012460 | |
| 2010-11-14 04:00 | FUBAR-BDHR | Note Added: 0012464 | |
| 2010-11-14 09:35 | Echelon9 | Note Added: 0012465 | |
| 2010-11-16 02:23 | FUBAR-BDHR | Status | new => assigned |
| 2010-11-16 02:23 | FUBAR-BDHR | Assigned To | => FUBAR-BDHR |
| 2010-11-16 04:29 | FUBAR-BDHR | Note Added: 0012466 | |
| 2010-11-16 08:23 | Echelon9 | Note Added: 0012467 | |
| 2010-11-16 08:26 | FUBAR-BDHR | Note Added: 0012468 | |
| 2010-11-16 08:33 | Echelon9 | Note Added: 0012469 | |
| 2010-11-16 09:07 | FUBAR-BDHR | Note Added: 0012470 | |
| 2010-11-17 10:09 | FUBAR-BDHR | Note Added: 0012471 | |
| 2010-12-09 23:30 | FUBAR-BDHR | Note Added: 0012530 | |
| 2010-12-09 23:30 | FUBAR-BDHR | Status | assigned => resolved |
| 2010-12-09 23:30 | FUBAR-BDHR | Fixed in Version | => 3.6.13 |
| 2010-12-09 23:30 | FUBAR-BDHR | Resolution | open => fixed |
