View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001196 | FSSCP | user interface | public | 2007-01-04 21:31 | 2012-01-09 18:06 |
| Reporter | Tahna Los | Assigned To | taylor | ||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.9 | ||||
| Fixed in Version | 3.6.9 | ||||
| Summary | 0001196: CTD when selecting greyed out Maxim gun | ||||
| Description | Reproduced in Derelict Mission: "The Horror in the Deep" - Go to the Ship Selection Screen. You should be in a Myrmidon. - Now go to the Weapon Loadout Screen - Select the Maxim gun (it is greyed out, and therefore inaccessible to the Myrmidon) - game pauses and crashes at this point. | ||||
| Tags | No tags attached. | ||||
|
|
I've tested and confirmed it. But the "ghost" weapon is "UD-D Kayser". I've opened the mission in FRED and in Team Loadout Editor UD-D Kayser is not selected. So, how the hell does it appear in the game? If you assign any amount of UD-D Kayser, then there's no problem. The gun is grayed out, but you can click on it. |
|
|
It's crashing because of a NULL pointer issue, there is no description for the weapon. The problem is that the mission is using the Targeting Laser instead of a Kayser. But I'm not sure if that is a mistake or what. The reason that it has the Kayser icon though, is because it actually has the Kayser icon, it's in the retail tbl that way. So while technically this is a mission bug, it does point out something that we need to address in the code so that it doesn't crash when something like this happens. It also pointed out a memory leak that I've just fixed. |
|
|
Hah..... Thanks for looking into it. I was thinking that it was either a maxim or a kayser gun since the icons look very similar..... But was thinking that since the player should not have access to the kayser gun at this point of the game, but maxim gun? Well it was a possibility. Besides, the Myrmidon is NOT supposed to be compatible with the Maxim, and it is compatible with the Kayser..... But yes, thanks for looking into this. |
|
|
Problem fixed locally. I'll resolve this once the code hits CVS. |
|
|
@Tanha Los: Be careful about EXACT names all over FS2 tables. I've said "UD-D kaiser" not "UD-8 Kaiser". Myrmidon is compatible with UD-8 but not with UD-D. ---------------------------------- @Taylor: Maybe there's another bug in FRED. In team loadout window, I can assure you that there's neither Targeting Laser nor TAG-C missile. But they appear in the FS2 file and you CAN'T fix it through FRED. They both appear in Weapon Loadout window ingame. Is this supposed to happen? |
|
|
@ARSPR: Nope, it shouldn't do that. I'll look into it before I start all of my commits later today. |
|
|
Ok, think I found the basic problem. When the mission is loaded it will take anything in the weapon pool, regardless of what it is, so long as it's a weapon. FRED also takes this, but it filters out weapons in the list which aren't "player allowed". It still keeps the count however, and will add those weapons to the list that is saved in the mission file. So I think that there are two issues here: 1) FRED needs to reset the weapon count for anything in the weapon pool which isn't allowed for the player, and 2) when the mission is parsed, it needs to do something similar to prevent strange issues for users. #-1 is easy, and I added a warning popup so that it knows this was fixed automatically, and you just needs to re-save the mission. #-2 will only happen when not in FRED, and will be silently fixed, except for a message in the debug log. Since non-player-allowed weapons may not have a proper setup to actually be used on the interface in the first place, I think it's safer to just filter them out automatically than to let them stay and see what happens. I'm not sure if anyone is actually trying to make use of this bug for their mod/mission, but it's something that they can get around if needed (just make the weapon player usable). |
|
|
Please double-check that it's working ok with this build: http://icculus.org/~taylor/fso/willrobinson/reboot.rar |
|
|
Fixered. |
|
fs2open: fs2_open_3_6_9 r3846 2007-01-07 07:18 Ported: N/A Details Diff |
safety check to make sure that we don't end up with non-player-usable weapons in the weaponselect pool (Mantis bug 0001196) |
Affected Issues 0001196 |
|
| mod - /branches/fs2_open_3_6_9/fs2_open/code/fred2/playerstarteditor.cpp | Diff File | ||
| mod - /branches/fs2_open_3_6_9/fs2_open/code/mission/missionparse.cpp | Diff File | ||
|
fs2open: trunk r3868 2007-01-07 07:55 Ported: N/A Details Diff |
safety check to make sure that we don't end up with non-player-usable weapons in the weaponselect pool (Mantis bug 0001196) |
Affected Issues 0001196 |
|
| mod - /trunk/fs2_open/code/fred2/playerstarteditor.cpp | Diff File | ||
| mod - /trunk/fs2_open/code/mission/missionparse.cpp | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-01-04 21:31 | Tahna Los | New Issue | |
| 2007-01-04 23:30 | ARSPR | Note Added: 0007385 | |
| 2007-01-05 00:54 | taylor | Note Added: 0007386 | |
| 2007-01-05 00:54 | taylor | Status | new => assigned |
| 2007-01-05 00:54 | taylor | Assigned To | => taylor |
| 2007-01-05 04:21 | Tahna Los | Note Added: 0007387 | |
| 2007-01-05 05:02 | taylor | Note Added: 0007388 | |
| 2007-01-05 12:16 | ARSPR | Note Added: 0007393 | |
| 2007-01-05 13:01 | taylor | Note Added: 0007394 | |
| 2007-01-05 16:22 | taylor | Note Added: 0007395 | |
| 2007-01-05 16:23 | taylor | Note Edited: 0007395 | |
| 2007-01-06 04:09 | taylor | Note Added: 0007398 | |
| 2007-01-07 13:16 | taylor | Status | assigned => resolved |
| 2007-01-07 13:16 | taylor | Fixed in Version | => 3.6.9 |
| 2007-01-07 13:16 | taylor | Resolution | open => fixed |
| 2007-01-07 13:16 | taylor | Note Added: 0007416 | |
| 2007-03-23 20:35 | taylor | Relationship added | has duplicate 0001240 |
| 2012-01-05 22:55 | taylor | Changeset attached | => Import 2012-01-05 17:52:05 fs2_open_3_6_9 r3846 |
| 2012-01-05 22:55 | taylor | Changeset attached | => Import 2012-01-05 17:52:05 trunk r3868 |
| 2012-01-09 18:06 | taylor | Changeset attached | => fs2open_websvn fs2_open_3_6_9 r3846 |
| 2012-01-09 18:06 | taylor | Changeset attached | => fs2open_websvn trunk r3868 |
